[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v5 06/11] xen/arm: add ASSERT_UNREACHABLE in allocate_static_memory


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <julien@xxxxxxx>
  • From: Penny Zheng <penny.zheng@xxxxxxx>
  • Date: Thu, 27 Jan 2022 07:49:24 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ADeT2DevMW88RBtpOZP9XyqhR303hWtW1f/VBC5H4k=; b=FaHwWwq1w4BUmm9nj74ATWuxD1T4sLijglvTn5IzLNG2wdroKvOviUB69jEV0PyZAd25nnxtQOMkE49kiTS54qoY+8K9iTEA1gehLNSUJcrW+ylMOys1uVv6fWyJVje3lVJSbQBOuLTvlNYF1xrIXU+5b1Ard+1uxOsWVknN+e/u91rEy4S3Zk3eFsR19FkYiW2lbE6ULQB8rz8UXZ5iGl+YmcdEjXjuOCNbgJQ6+La+SWh3kegAC0IgW2qYiEfWiF1+Uwmm142i3+reJQmg5gT7XGEcQf5jz4Ll95Z/PbmuZtcEnYEYCpfoA6ZLbQmxoJmZw/eSvZjsgdm8LnbnYw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WCW6lGP8Nwbc9guDJDgDin3T5X8WFfNzB4cxbjPIpQE+m8Bpw8qIkY5II2gbvI59AiVLHVYcas1aRRtzHj2vzhEoyBv3hndU0xotzFR+jvO83yMkv12xQZYZy4qyqWfbZLAOMmd2+MHs0D7B/rNqw04MY8UVEveSBk/mZz+78aj9aqgOCJf1D3Kw67gjTC6EU60pTghKeVULkzJsntpANBrGLZx5NgjrCFP6l+fQT7HBWnA1XD5zwI9+ucjxIrMAUEaGbjMNCauNLADS1tH8uCo7KsxjcAOcfSIP7KuTFbZtxXPfsKZM615qOO7iNsCW2ZCAYOUcGYDYG9yXbombyA==
  • Cc: <Bertrand.Marquis@xxxxxxx>, <Wei.Chen@xxxxxxx>
  • Delivery-date: Thu, 27 Jan 2022 07:50:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true

Helper allocate_static_memory is not meant to be reachable when built with
!CONFIG_STATIC_MEMORY, so this commit adds ASSERT_UNREACHABLE in it to catch
potential misuse.

Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Tested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
v3 changes:
- new commit
---
v4 changes:
- nothing changed
---
v5 changes:
- nothing changed
---
 xen/arch/arm/domain_build.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index ec29bd302c..52f256de9c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -755,6 +755,7 @@ static void __init allocate_static_memory(struct domain *d,
                                           struct kernel_info *kinfo,
                                           const struct dt_device_node *node)
 {
+    ASSERT_UNREACHABLE();
 }
 
 static void __init assign_static_memory_11(struct domain *d,
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.