[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 2/5] xen: export get_free_port
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 26 Jan 2022 08:30:35 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JmtMMuS2hcA8W4tX+j+C+yJxQBfFZ8yEL6wHR22FHPE=; b=bB/dd2Ddvo6qRcvI1bf/e/QXPyriOA6UdgFRm7O16uCC4N9fcaZD6UD4ZqO60j00Cgfn/T5W6tbhb+KwfVIS6Mtd8DcRSSX+LNptiU7+LUQRvHTPsHc+l6NfMclq0AOTEoZHjhHnpnXy1ynAj5cx/KpymxhmrQillkxzIdFQfs7qh6hdOMCg48OidisvaKv4DFlI+m3x2h1US2HtCNejFDJdHAbuZAV323WFTIb3yOSx4IHuupbjvMUU6e3tKy1XCKxBTNLosrQfvGm+XXhyx5lBFPVzGitutdGy9KRutW58X8tpgVhlIxIXDollK4OK/4QTfjhrif61xET8HGqDyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBhlZR+rX51PMNghgALhL5JLQKsgA1NhQ7THla3KPIYbiYhT6077Z8FJ0Z81zB9a1CPUruirOKr5wpp8mmDx6maNQIWlQ6FbMfly84yPcKEn204uWbN63kb6G6kTewnbYstzHh8eanoh3jIpHpEuWlYLMHJomKRlQVI/YhWW9EvMUbvZPtxydBLMwosnAdTIbSkMKov4yR7M/OZ2g7CBIofCIemrvaDaPa6vuLSXZzWLkdE6WVCTTbPrDPV8bsMEuv+JC/PRMuKsRaZk2GZ0HB0VsMkPmZ1Y0rr5PAnuak4V6ynymJNvOrpZmuNwvwIVlnjB79XtWx9E5l2auItL9g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, jgross@xxxxxxxx, Bertrand.Marquis@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Wed, 26 Jan 2022 07:30:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.01.2022 02:03, Stefano Stabellini wrote:
> Are you guys OK with something like this?
With proper proof that this isn't going to regress anything else, maybe.
But ...
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -92,7 +92,9 @@ static always_inline int xsm_default_action(
> return 0;
> /* fall through */
> case XSM_PRIV:
> - if ( is_control_domain(src) )
> + if ( is_control_domain(src) ||
> + src->domain_id == DOMID_IDLE ||
> + src->domain_id == DOMID_XEN )
> return 0;
... my first question would be under what circumstances you might observe
DOMID_XEN here and hence why this check is there.
Jan
|
