[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 10/37] xen/x86: use helpers to access/update mem_hotplug


  • To: Wei Chen <wei.chen@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 24 Jan 2022 17:29:54 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x0TkUH3x/EEJXXR+NO6BZEI51INDb8h8sa/CRb7WX84=; b=GR85ErBUOAohNsbSrHAb3XWRYWXMTeEt4l75Zno+ZiI9VE5lOhfKO/yKMbOi3QSmryISke8upANYm78JrqowEfXuL8q7xP7ELcAlx14zQuPQmMNHqEQJ6CAkdYjP3YZXeTDKXRCEu71qD0Ok5f86KVuhY6nH1/nritUJvhmsUWMP1hx52BFH6geq3QRlyoQ3IAejCnK0VGCnYJyBqAVm8sSTJVz/gAiwSCLxUHAZSqzjrwRlmFDUi4LVgEwl1otReskxkN8gfNAtuBE/LofDdmbLfBAeisGueZ9Csf5ARzKzVwCx97DuLTNJOYKk6naJ3Zk2WOhx7a9BhQsnLgK8FA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CzF9hMrq39QO4GC6/mlHoV+WuGeOpfZOA0jGPzKPxR8uvWxOOlgmwJqzRkAV5JEdtztDJta23g1wh0Ks1Rvvo9AVHBLDqrsw4XUDcoozI1gPovbqBpe34S2+XarG98h7OjuiTsvM2DcFnAUsHVLaSyfF2JIRgRGmM3W/RzePsxtynRYMxT/CNDPnVORNSguUHU0yjD3RQwGJXkvLZwn7DHdqoC0KM5UbsCbTvOC/6eRqqIvgXNdlJ7bMvkgln5adzHNXypUAi5yHWULRUmtZ79AqSH/2J3b/1ZRaD4Doy5v2+PaYPnS+zghNS8lRwgrMRXPA7VQtJvOXa4g3/qozVw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand.Marquis@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, julien@xxxxxxx
  • Delivery-date: Mon, 24 Jan 2022 16:30:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.09.2021 14:02, Wei Chen wrote:
> --- a/xen/arch/x86/srat.c
> +++ b/xen/arch/x86/srat.c
> @@ -391,8 +391,8 @@ acpi_numa_memory_affinity_init(const struct 
> acpi_srat_mem_affinity *ma)
>       memblk_nodeid[num_node_memblks] = node;
>       if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
>               __set_bit(num_node_memblks, memblk_hotplug);
> -             if (end > mem_hotplug)
> -                     mem_hotplug = end;
> +             if (end > mem_hotplug_boundary())
> +                     mem_hotplug_update_boundary(end);

Can the if() please be folded into mem_hotplug_update_boundary(),
eliminating (at least for the purpose here) the need for the
separate mem_hotplug_boundary()? As said on the previous patch,
I think the two want folding.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.