[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/19] rnbd-srv: simplify bio mapping in process_rdma
- To: Jinpu Wang <jinpu.wang@xxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Thu, 20 Jan 2022 09:37:46 +0100
- Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Pavel Begunkov <asml.silence@xxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "Md . Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, ntfs3@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx
- Delivery-date: Thu, 20 Jan 2022 08:37:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jan 19, 2022 at 01:20:54AM +0100, Jinpu Wang wrote:
> this changes lead to IO error all the time, because bio_add_page return len.
> We need if (bio_add_page(bio, virt_to_page(data), datalen,
> offset_in_page(data)) < datalen)
Does this version look good to you?
http://git.infradead.org/users/hch/block.git/commitdiff/62adb08e765b889dd8db4227cad33a710e36d631
|
