[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] x86/mwait-idle: add SnowRidge C-state table


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 19 Jan 2022 13:03:22 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JLDoJGqeyVOqoYGF1B9eA2OtkKsDK5I4ihKh3wUrkw4=; b=O14oxO59KqoApPo55h3nQRypJNdW/WXfpNEX5BkJprDIpS3SUK1AgNfwDQ+rRUNaLl9At4iU/LRHTrM4JHqaX0uEklUVgeTjQnyLUWW8ahdaLc38lrIFMHpNBlpHyv1S/STMvuCSFZ3uS+d2EdZgtSeCa+AcEkeS6jSTd9ICXHTvNZWHhglv/fjC9EDdvJcsUw3dI0V73YcvPdv+HI7NFlx+FquudtR1vngVsl5ys7WBXvRxA7KpLpjPA9ejl/s885UuwQLJ+DsLTpeW6+qYnGPO1yvWB1XboJCI312iocSyb8pr5k1flJBE2QoAVJYXlIKhh0kVQRW5pP0c2dC27w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bsHNGjmSgwc9jB50b6CugQ6v6hOedaQV1KGkCMi2jwNpKQw3wkG4RiPkhf1m5scIB2F7Tl1fK2E53hnTevGX/Gudo0Q8I4Npms/72FtTSbAvYuKQ6UvqhNFtIxjET8ZWn9nRH738pbm1/NVvLiMz6VU5j5Lu2my9jhlq5F4rdgchImot/RY6U8CJb/c7JCW326DhzUaxXTyPc7RcIt2ciT87UQABvUCJbb/iP3x86RlidMDhXCetBIZFWVTg9r4czXGn618UgwWr6YX9tpjzG33FUi93xYp40LzGS2o9rFPLFMOn7zyPRbNcXiE+p3L0FUGNNczwmNlr9WFY5Pw2dQ==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 19 Jan 2022 12:03:58 +0000
  • Ironport-data: A9a23:BCdBYqNKUZvTSR/vrR1EkMFynXyQoLVcMsEvi/4bfWQNrUp3gzQHz mIZUWCOPPaOZGPxetwlYN7loBxUv8SHzdUyTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6UUsxNbVU8En150Esyw7dRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYoyuuo/Qyx /xPjqCfDhkWAvPcmcobYiANRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/uQuocIg2ht7ixINfbgY o0GYyUwUE3BRz8SMXQ8NYkTsvj90xETdBUH8QnI9MLb+VP70whZwLXrdt3PdbSiVchT20qVu G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOGTeKR0xDkHYgFc gpNp3Ro/fNaGFGXosfVQTqEhD2LlxwnZ/UXDdIGthGM5Kzl2lPMboQbdQJpZNsjvc4wYDUl0 F6Vgt/kbQBSXK2ppWG1renN827rUcQBBSpbPHJfE1NZizX2iNhr1kqnczp1LEKiYjQZ8xnUy ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCuf/AjPNAuBRPtfNi2mUBb7zt6YowGGxFAjpg ZT8s5LChN3i9LnU/MB3fM0DHauy+9GOOyDGjFhkEvEJrmrxoSP4JNwKv28kfS+F1/ronxezM Cc/XisLtfdu0IaCN/crM+pd9ex3pUQfKTgVfq+NNYcfCnSAXASG4DtvdSatM5PFyyARfVUEE c7DK66EVC9CYYw+lWbeb7pDjdcDm35vrUuOFcGT50n2itK2OS/KIYrpxXPTNIjVGove/lWMm zueXuPXoyhivBrWOXiIodVNfAFTfRDWx/ne8qRqSwJKGSI/cEkJAP7N27IxPYtjmqVejODT+ X+hHERfzTLCabfvcG1ms1hvN+HiW4hRt3U+MXB+NFqkwSF7M42u8L0eZ908erx+rL5vyvt9T v8kfcScA6sQFmSbqmpFNZSt/pZ/cBmLhB6VO3b3ajYIYJM9FRfC/cXpf1Wz+XBWXDa3r8Y3v 5apyhjfHcgYXw1nAcuPMKCvwlq9sGIzguV3W0eUcNBfdF+1qNphKjDrj+9xKMYJcE2Ryjyf3 geQIBEZueiS/NNlrIiX3fiJ9t77HfF/E0xWG3jgwYy3bSSKrHC+xYJgUfqTeWyPXm3D56j/N /5eyOvxMaNbkQ8S4ZZ8Cbti0Yk3+8Dr++1B1g1hEXjGMwarB7dnLiXU1MVDrPQQlLpQuA/wU UOT4NhKf76OPZq9QlIWIQMkaMWF1O0VxWaOvahkfh2i6X8l5qeDXGVTIwKI2X5UI7ZCOY84x fss5ZwN4Aulhxt2atuLg0i4LYhXwqDsh0n/iqwnPQ==
  • Ironport-hdrordr: A9a23:Y2pRu6xvt0yg3Mhc/yhMKrPw871zdoMgy1knxilNoHtuA6ilfq GV7ZEmPHrP4gr5N0tOpTntAse9qBDnhPxICOsqXYtKNTOO0ADEQL2KhrGSoAEIdReeysdtkZ 56da5wEdvxCkU/o/rbzWCDYrEd6ejCybuvg+jGyXdrUEVNUIFPqylEKivzKDwReOFhbaBJbK Z0IvA33gadRQ==
  • Ironport-sdr: jvMCmv4cHK5Z4uALZ3Lq0A3C9oVmsCdRtKKlybDhQjFXM2/ICjLdHwIHrM3RwJ2y54oNU6bN7X DLeM+LP8Xj0d2aT6c6Tr/7CFbkk6g4hO+c4kZAe4ojtA86dFVM+yETp6FYqeeODBBpCa+Z/MTh bs8rGm85PrKBxva3/fFPcTwZvE+9UHSJyzaq/aFtCDfnzkncCMfQjX0aFaUGERCP2VpREDt5Ym z4AY/+1+QI/DBgEYsDRlEC6/jvQNVSMK5gsMBW6NEXd9P1AFoFszpLBmzJojWdw6mIFLlvPAWy Xv304our2pwglbyqxwXUQTTI
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 18, 2022 at 03:05:54PM +0100, Jan Beulich wrote:
> On 18.01.2022 11:17, Roger Pau Monné wrote:
> > On Mon, Sep 06, 2021 at 03:00:46PM +0200, Jan Beulich wrote:
> >> --- a/xen/arch/x86/cpu/mwait-idle.c
> >> +++ b/xen/arch/x86/cpu/mwait-idle.c
> >> @@ -742,6 +742,32 @@ static const struct cpuidle_state dnv_cs
> >>    {}
> >>  };
> >>  
> >> +/*
> >> + * Note, depending on HW and FW revision, SnowRidge SoC may or may not 
> >> support
> >> + * C6, and this is indicated in the CPUID mwait leaf.
> >> + */
> >> +static const struct cpuidle_state snr_cstates[] = {
> >> +  {
> >> +          .name = "C1",
> > 
> > We usually use names like "C1-SNR" or similar in other cpuidle_state
> > structs. Is using plain "C1" intentional here?
> 
> I don't know. We're simply following the Linux side change. If we're
> unhappy with their naming (it indeed looks inconsistent), then we
> ought to make a separate patch on top (and maybe submit that also to
> Linux).

Looks like at some point Linux dropped the '-SNR' and similar suffixes
from the state names, so we should likely import that patch as a
pre-req for consistency? It's commit:

de09cdd09fa1 intel_idle: stop exposing platform acronyms in sysfs

> 
> >> @@ -954,6 +980,11 @@ static const struct idle_cpu idle_cpu_dn
> >>    .disable_promotion_to_c1e = 1,
> >>  };
> >>  
> >> +static const struct idle_cpu idle_cpu_snr = {
> >> +  .state_table = snr_cstates,
> >> +  .disable_promotion_to_c1e = true,
> > 
> > This likely wants to be 1 because the type is bool_t.
> 
> bool_t is just an alias of bool, so "true" ought to be fine. We may
> want to follow Linux in switching to bool altogether - iirc we didn't
> have bool yet at the time the driver (or the first commit needing it)
> was ported. I guess I'll make a patch ...

OK, thanks!

I guess for the patch itself then:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Would be nice to get those things fixed for consistency.

Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.