[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/19] block: pass a block_device and opf to bio_alloc_bioset
- To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
- From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
- Date: Tue, 18 Jan 2022 22:12:25 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uQcGE2RD5vm8sY+bJefQtU5ebnJe2jUx0ztTnDFLA3c=; b=V1WznV5siXl1FGLGS2ZmNGU981eLIfwEAJ01DX3Y5YkFPR0u/Iil7yxx+6iBAXowNYzn7Ia3fcGjwAvS9KgT1V1wSUbzUlVZQkyJH7zaqaIL6S3wMAoLnMYAFKeNErtUVZHX6RhA/saJe1oj0VpOgAWFDnMrDusuaTPvcYSgn0/UeDLB1g2TRNVZKjRtwfzesNpfaCECuM//N2nfdgNBtuEsF4ItiZk8BlWR1Z0t2+mmpdrRlLSNmD/+W5aL/rf2YSjCZAgb5qM+MkdpKODPwRZoj5R2FxWZbGFkab0/wBt7cbgOFhaNZv1grpTiHVIXURHO9cxSOh93UzJrp9jT3g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jKR/HKXa4felQpSIvpc4TxodyJEUY56WZUGTzwDSvvK+hktw56PHM2zDjP6ur8VGV86RgDWRcgK9WCpYgujHk5Mg6aQVqscbYbg4dhKW0VfYMzeq5Lz7QkEasfni2tIEegBhKucjcX7pyFCQ51yngR0koTaa8wtf8eHE8Rsb3Sn/m1yTlaMlCwiQDVCAZEyCYbdgMVx3jlyxMBpC5P+m33/0YnkxA3+KaWwU1ea5ATeZlEKg3gD8Cg0F1w6c+fjmR0BYtYT+8n0jT8mROVK+fAGIlD76MXlkzlpvyZ5TUoNKxZWeMCckePYfabBPOMb6FP0Pm2V3FAUBYWCUrv11kg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com;
- Cc: Pavel Begunkov <asml.silence@xxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Konstantin Komarov <almaz.alexandrovich@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "Md . Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-nfs@xxxxxxxxxxxxxxx" <linux-nfs@xxxxxxxxxxxxxxx>, "linux-nilfs@xxxxxxxxxxxxxxx" <linux-nilfs@xxxxxxxxxxxxxxx>, "ntfs3@xxxxxxxxxxxxxxx" <ntfs3@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "drbd-dev@xxxxxxxxxxxxxxxx" <drbd-dev@xxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 18 Jan 2022 22:12:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYDDwKaEQTLVOZi0Cg/CObFHXAKqxpWHgA
- Thread-topic: [PATCH 15/19] block: pass a block_device and opf to bio_alloc_bioset
On 1/17/22 11:19 PM, Christoph Hellwig wrote:
> Pass the block_device and operation that we plan to use this bio for to
> bio_alloc_bioset to optimize the assigment. NULL/0 can be passed, both
> for the passthrough case on a raw request_queue and to temporarily avoid
> refactoring some nasty code.
>
> Also move the gfp_mask argument after the nr_vecs argument for a much
> more logical calling convention matching what most of the kernel does.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
|
