Xen project Mailing List

Re: [PATCH v4] xen/arm: Allow QEMU platform to be built with GICv2

To: Dongjiu Geng <gengdongjiu1@xxxxxxxxx>

From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>

Date: Mon, 17 Jan 2022 11:38:33 +0000

Accept-language: en-GB, en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iVobulXZF0s4vQ1oewlAvhCdEuRHV3M3/IVuxIgXPYs=; b=Q4XNcWPImm0nKl9bt/NOSA2WjD7HLUGDBu2Ib+H9+RMqOv8m1oN2M2W4j7tzxfuHe/Ms6bHr02n0SvO31medNDC8j6yUK8mYcq7cr1I1Jk9vxBxQ4se/0OLohBV+4Aa6PnKW+1dNQzy7Y16nUetBzknbAXq0k9AjZRWgwxWxXcENVujx6cbBkUVBVFAht+6JtYzJWKKj0BD/DQhZh18njGVYZSrPl2DrjT/WjWNQNJgB5aetx9LWPXhnAiTP46asuAs9NBw6vHi5J/eOKFRMa3Q4RoRPayMnZOJAN7zNziuqPPvy/gYzGEmE3NukPHqja48fwdvmHxq7mBwIlV4OuA==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tlnaeub+wyeCwU514TpXihlqQSSibHq7vGTD76004s5r0KclHgtdAResdKPntUB/Jzz+jkRlL031jgX8AOjMVIf2YyYH1bywoWQD6r6t16qq82W0EMJJ7F5hQGHBdUigtPhqXJAMu47MmEqz6B7t6xZP6K1DQEAngXt2WJoXVAAZIN20VlZrJZfvEEyGjzXrOPP2sPkZ1JTKX/a/dZhNEY+bvSLmLQvTy3ZOj7VZZ/6XBDBSieLjKzSTUzIrE5FiPX9HqyS6X9ZEoF771ySqr/g8bfRd6bOZuYt9bsklOnUy8AXkLhhAunukQwbNU89KABS/vrwpDOd13fSixJ5Yow==

Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;

Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>

Delivery-date: Mon, 17 Jan 2022 11:39:04 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Nodisclaimer: true

Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;

Thread-index: AQHYC20k2h7y374id02KJynAohV9hqxm6mCAgAAk64CAAAdegA==

Thread-topic: [PATCH v4] xen/arm: Allow QEMU platform to be built with GICv2

Hi, > On 17 Jan 2022, at 11:12, Dongjiu Geng <gengdongjiu1@xxxxxxxxx> wrote: > > Bertrand Marquis <Bertrand.Marquis@xxxxxxx> 于2022年1月17日周一 17:00写道： >> >> Hi, >> >>> On 17 Jan 2022, at 06:40, Dongjiu Geng <gengdongjiu1@xxxxxxxxx> wrote: >>> >>> It turns out that QEMU has been supporting GICv2 virtualization since >>> v3.1.0. So remove the dependencies on GICv3. If we want to use GICv3, >>> we can select the QEMU_LEGACY configuration. >> >> I am bit puzzled by this change introducing a legacy option actually >> selecting the newest GIC interface. >> >> Can’t we do the opposite and introduce a QEMU_GICV2 instead ? >> >> Also why do we need to remove gic-v3 support ? The code should actually >> select which gic to use depending on the device tree. > > QEMU platfrom only select GICv3, so I remove this limitation, let > user or developer selects gic version is better. This is where I am lost, the code is actually always compiling gic-v2 support in unless new vgic is selected (see arch/arm/Makefile). Cheers Bertrand > >> >> Regards >> Bertrand >> >>> >>> Signed-off-by: Dongjiu Geng <gengdongjiu1@xxxxxxxxx> >>> --- >>> xen/arch/arm/platforms/Kconfig | 10 +++++++++- >>> 1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig >>> index c93a6b2756..41e82a42ee 100644 >>> --- a/xen/arch/arm/platforms/Kconfig >>> +++ b/xen/arch/arm/platforms/Kconfig >>> @@ -13,7 +13,15 @@ config ALL_PLAT >>> automatically select any of the related drivers. >>> >>> config QEMU >>> - bool "QEMU aarch virt machine support" >>> + bool "QEMU aarch virt machine support >= v3.1.0" >>> + depends on ARM_64 >>> + select HAS_PL011 >>> + ---help--- >>> + Enable all the required drivers for QEMU aarch64 virt emulated >>> + machine. >>> + >>> +config QEMU_LEGACY >>> + bool "QEMU aarch virt machine support < v3.1.0" >>> depends on ARM_64 >>> select GICV3 >>> select HAS_PL011 >>> -- >>> 2.25.1

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.