Re: [PATCH v2 16/18] mini-os: reset file type in close() in one place only

[Juergen Gross <jgross@xxxxxxxx>]

On 11.01.22 20:14, Andrew Cooper wrote:
> On 11/01/2022 14:58, Juergen Gross wrote:
> > diff --git a/lib/sys.c b/lib/sys.c
> > index 0e6fe5d..323a7cd 100644
> > --- a/lib/sys.c
> > +++ b/lib/sys.c
> > @@ -424,87 +424,82 @@ int fsync(int fd) {
> >   
> >   int close(int fd)
> >   {
> > +    int res = 0;
> > +
> >       printk("close(%d)\n", fd);
> >       switch (files[fd].type) {
> I know this bug is pre-existing, but the libc close() really ought to
> sanity check fd before blindly indexing files[] with it.
>
> I'd tentatively suggest that you want one extra goto from here, into
> wherever the EBADF logic ends up, and it's probably worth including in
> this patch.
Will do that.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature