Re: [patch] genirq/msi: Populate sysfs entry only once

[Borislav Petkov <bp@xxxxxxxxx>]

On Mon, Jan 10, 2022 at 07:12:45PM +0100, Thomas Gleixner wrote:
> The MSI entries for multi-MSI are populated en bloc for the MSI descriptor,
> but the current code invokes the population inside the per interrupt loop
> which triggers a warning in the sysfs code and causes the interrupt
> allocation to fail.
> 
> Move it outside of the loop so it works correctly for single and multi-MSI.
> 
> Fixes: bf5e758f02fc ("genirq/msi: Simplify sysfs handling")
> Reported-by: Borislav Petkov <bp@xxxxxxxxx>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
>  kernel/irq/msi.c |   11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> --- a/kernel/irq/msi.c
> +++ b/kernel/irq/msi.c
> @@ -887,12 +887,11 @@ int __msi_domain_alloc_irqs(struct irq_d
>                       ret = msi_init_virq(domain, virq + i, vflags);
>                       if (ret)
>                               return ret;
> -
> -                     if (info->flags & MSI_FLAG_DEV_SYSFS) {
> -                             ret = msi_sysfs_populate_desc(dev, desc);
> -                             if (ret)
> -                                     return ret;
> -                     }
> +             }
> +             if (info->flags & MSI_FLAG_DEV_SYSFS) {
> +                     ret = msi_sysfs_populate_desc(dev, desc);
> +                     if (ret)
> +                             return ret;
>               }
>               allocated++;
>       }

Yap, works.

Tested-by: Borislav Petkov <bp@xxxxxxx>

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette