[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: fix make distclean
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 10 Jan 2022 09:42:48 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZtUsklSb+M1LdlTEkS/ih+4NH1LQS8z1Xrr+PfO3BCQ=; b=AJJDNe+hbXLntsDey5yhmUEle1DqCgv7pxVqExd05Tc6nHWeHli1Qz7kmb9dAjk67s6bLX/3rdQd3BmzrrBhPEOIvR9b8QUQQNqAIRr9bpjF3Mmo/6KCv4KXb+6B2b8viZtsZEEvnNrnEi0l8Pw5QbK7k0+emaXORw+6vXQ9bmFos/c4nX/NnGTtjvKMqZaqcWGfTHeyEWo4y3rT1DxyyiKxficNriD0F3bRbr7o9dM1hXMWaJcjZayI8tchIlyV8NYrgfrA8wO8uM7mFfjjUuT1UdfqB7HgrXNBr4xHDGRTPfKrytU5YFu+g6C/MZWVnqyRgMkl3P2v/QTb3iq+5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bgSkjCLxI/D0n6ZCKECVThzWEc66I4r8TbLGiJjjkxBRKFLaikcoqpbBBnmpPHaWIBJ676e7QLHHVsVQf60tlmHflCrBNp/6C82HpQQTmdR0f9/j71t3opevN00kL+VnDyLsAKGo91iiadGFiw601VJa+lQCsthcwKBhn1J42B5/H4EmMx+QcdGHNh3vYi34WcEvwH9CVwwtO7rxxHRACYi2qm4hEynXJMZgHE/C+7rIcySmsllsDMeYv+kL8H6VrLHS/z7zxYRhvOAHKEmdd91J9K8WNvuXqFq7EIN5FOqSGVUCDrrihINufgHWWnHFsTinAtMI7UtF1XA2wdm7cQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 10 Jan 2022 08:43:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.01.2022 11:01, Juergen Gross wrote:
> "make distclean" will complain that "-c" is no supported flag for make.
>
> Fix that by using "-C".
>
> The error has been present for a long time, but it was uncovered only
> recently.
And that's because the rule simply was unreachable before? Or it was
reachable, but only via special (non-default) $(MAKE) invocations?
> Fixes: 2400a9a365c5619 ("tools/debugger: Allow make to recurse into
> debugger/")
> Fixes: f9c9b127753e9ed ("tools: fix make distclean")
To distinguish from this commit's title and to also identify the affected
component, how about having "gdbsx" somewhere in the subject? (To be
honest, with this title I wouldn't even have expected the issue is in the
tool stack part of the tree.)
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Preferably with the above taken care of (which could be done while
committing, provided suitable adjustment suggestions),
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
> --- a/tools/debugger/gdbsx/Makefile
> +++ b/tools/debugger/gdbsx/Makefile
> @@ -14,7 +14,7 @@ clean:
>
> .PHONY: distclean
> distclean: clean
> - set -e; for d in xg gx; do $(MAKE) -c $$d distclean; done
> + set -e; for d in xg gx; do $(MAKE) -C $$d distclean; done
>
> .PHONY: install
> install: all
|
