Re: [PATCH 0/2] mini-os: remove device specific struct file members

[Juergen Gross <jgross@xxxxxxxx>]

On 07.01.22 12:30, Andrew Cooper wrote:
> On 07/01/2022 10:47, Juergen Gross wrote:
> > This small series is a followup to the series sent recently:
> >
> > https://lists.xen.org/archives/html/xen-devel/2022-01/threads.html#00110
> >
> > It contains the last cleanups related to struct file and can only be
> > applied after the Xen libraries have stopped using the related union
> > members.
> >
> > Juergen Gross (2):
> >    mini-os: remove event channel specific struct file member
> >    mini-os: remove gnttab specific member from struct file
> >
> >   include/lib.h | 13 -------------
> >   1 file changed, 13 deletions(-)
> This all looks fine.  Even if we don't want to hide struct file,
> shouldn't we at least make the files[] array private to the MiniOS
> core?  It's another implementation detail which external users mustn't
> rely on.
In theory yes.

This will need some more work either by splitting headers or by
using get_file_from_fd() everywhere in Mini-OS.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature