[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 16/18] x86: introduce helper for recording degree of contiguity in page tables
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Jan 2022 10:00:33 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EEAqyrFzTe7CraWNa6ySIpD+D56Cbi1riRoV+vFlOs4=; b=M++KkhgCLcpbCIanlbzoKo0mQsVDYd9WDvLxWiEE+n+uL4qOrLERRIqSgoeYAE3VMrLdkmzgLFZE230QeBVJ+hFYELfmDLJ01mTS65jAzXhHlGCLwtfNyb13aWlDtLJeMJzbTwjRcVOqoSE/b3SLFU7cEZ8fsx6se0ap8hft5X8CNRg/U2eHzWj+lzQmjUpui5mdSRpejeAqiYyXE4kpY3n3Bs5B5yLskbXC3urnivaymolKw3Bwvfesss8Iyq0CnhfZe0xaRi9gWhUnKbwAdoovaqOshYuzLHBZxXZv3yI55iyc02yqc69pc6/s/RIaZ8YcTxZygJUOate/PoNkdQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WNE2Le4g9z8Sk+LPym8MT7n3kJOhqi5MTtZPzA9acKFSS8Xmn1bMav2I1Q2zHG5cwxY6pt4EzlnuVfKaVeb09P3hFFXtTfEhHxwfokdYBHhq/CLAollZjHtQgsWUysO0OH1bisKIs17mQpJip9JYcWSI71K5mq5pR6CLrf8upE6bqmlKuzWQbCNa/7gSQ7RHnuiR3wImqVBUr2/flSnmK4NrE1478iBQISQaFwxeaeyali7IUNpXt6jmUyiPA3eHEfwin034PK9lQgsoFbriBSOfeYr2rusQhZDeKSG2dijAigYsCklByvZC8gXDl8IMVKsVJMccybd/D7pM8IMmgw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 04 Jan 2022 09:00:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.01.2022 09:57, Roger Pau Monné wrote:
> On Tue, Dec 21, 2021 at 09:09:45AM +0100, Jan Beulich wrote:
>> On 20.12.2021 16:25, Roger Pau Monné wrote:
>>> I think it might be interesting to add some kind of unit testing to
>>> this code in tools/tests. It's a standalone piece of code that could
>>> be easily tested for correct functionality. Not that you should do it
>>> here, in fact it might be interesting for me to do so in order to
>>> better understand the code.
>>
>> Actually I developed this by first having a user space app where I could
>> control insertions / removals from the command line. Only once I had it
>> working that way was when I converted the helper function to what's now
>> in this header. But that user space app wouldn't directly lend itself to
>> become an element under tools/tests/, I'm afraid.
>
> Also, I'm curious, did you develop the algorithm yourself, or is there
> some prior literature about it?
I would have added some form of reference if I had taken it from somewhere.
Jan
|
