Re: [XEN][RFC PATCH v2 02/12] xen: arm: Add CONFIG_OVERLAY_DTB

[Julien Grall <julien@xxxxxxx>]

Hi,

Please add a short commit message explaning how this is going to be used.

On 09/11/2021 08:02, Vikram Garhwal wrote:
> Signed-off-by: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
> ---
>   xen/arch/arm/Kconfig | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa682..895f0ee 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -46,6 +46,14 @@ config HAS_ITS
>           bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
>           depends on GICV3 && !NEW_VGIC
>   
> +config OVERLAY_DTB
> +    depends on MPSOC_PLATFORM
None of the code looks to be Xilinx specific and this will prevent one 
to build a generic Xen and test your code. So can you remove the dependency?
> +    bool "Enable DTB overlay"
> +    default y
In general, for new feature, we want to disable them by default and gate 
them with UNSUPPORTED.
They can move off UNSUPPORTED once they are ready enough to be supported 
(and possibly security supported).
Cheers,

--
Julien Grall