[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
- Date: Wed, 22 Dec 2021 12:20:46 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5sQtXmss7+JD4k3X/wDoVr1jBwUqb1d3ZzH89G0Cnc0=; b=nsaYm2dCuGC5XsFXUVIBcnS5Mae+3QYMeza3lwI7diC7Ocg8/tgmonTSfSpdnGSHiCQ6hY2ljRQSSfEnRhVGrf5fNPZcEVfCW16sa83aQ6ADUQDAwg5VhyBL0jcAmzmV3zG625fxdGpfmU0wtW90VrFcTKYRqgWOOQetT/WXnrA2rPVhGlFNgPHuImsm+8xhXrLMj7+x51wKJITNcshbpelkN5eCdrIVCSWNNwb1FzNy2z1qHIdofBthZPagnD6xVoH/WzbDPwfhy8YU9XQSBRne3U1hkP9gE8uWyaFWNc2bkKrqQyvWh7d5nCjL0u6J1g4SMjY8jp+kXlY1q0KIOg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QD7MDclPqe3pgAsCvSKBoDq0YKjJFPEewEiZDZu2sw1SGOLIb+dMPFzLZOjgyk/7XLS1YAxLlHlllKLziro+ajDFskR3FnelLpS3NoW0ZQ5Glbq3q2uPUY1imJyEr4l778BkatJDgih9pM+v6UIN/d4hPCTFv9uFbJeoqO4TUe8/dAj34Xmjp+CxrUkCH7D0XYrjgkVAzXu+Ca2tkd869j0lzYg6kxVzO8Mq+0W7DmIBmmNpv7/kkm6eDvj+bWbxNMrNCO/noFLbkXAXXrTMBeVUzP8Ibh8Y7+f2vcqMPwQVlM+RBZaKO2p+/7Tu1gvNDtyZqjNlhJ2/AnZu3eKOgA==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 22 Dec 2021 12:21:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX8M3K+4k+NJRDpU6TSJ1TAn9Owqw8+0+AgAF/xgA=
- Thread-topic: [RFC v1 4/5] tools/arm: add "scmi_smc" option to xl.cfg
On Tue, Dec 21, 2021 at 01:27:11PM +0000, Anthony PERARD wrote:
> On Tue, Dec 14, 2021 at 09:34:28AM +0000, Oleksii Moisieiev wrote:
> > This enumeration sets SCI type for the domain. Currently there is
> > two possible options: either 'none' or 'scmi_smc'.
> >
> > 'none' is the default value and it disables SCI support at all.
> >
> > 'scmi_smc' enables access to the Firmware from the domains using SCMI
> > protocol and SMC as transport.
> >
> > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@xxxxxxxx>
> > ---
>
> Thanks for the patch, it looks good too me.
>
> But it is kind of weird that the manual describes something that isn't
> implemented yet. Could you maybe add in the patch description that the
> feature isn't implemented yet or that the feature is implemented in
> follow-up patches?
>
> Also, about the golang binding thingy, could you add a note after a line
> of a three dash "---" that let know the committer to regenerate
> everything that needs re-generating due to change in the *.idl file,
> just in case?
>
Hi Anthony,
I will add golang bindings in v2.
As for the scmi_smc description - is sounds reasonable. I will refactor
it in v2.
|
