[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v8 31/47] build: specify source tree in include/ for prerequisite


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 21 Dec 2021 15:16:25 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GkaCEXNhsQM+1BxFqscUz+K4mN1vCuV44dD608ybx2o=; b=WDMY5/MRBZbHZ4HomfOTZryZtEiUXLAX8UB20S9Z8l7eKtutzQaRzjuEJuWMkljsaotQFHI2N9FsjzM81Vy5fC+D8rigZx7u7CWti+it57+0lznZPNF6Zz9Sus+ghRhv76JXu0W25Fmttz2V3NFP/yGQIgoBzN5Fq4K/25MypsJt1bRXMa9MCAuYhwFuZGxXqezHC/iy6ac6hZ2RKOfFeml9zVbPqvslUB3ZzN9wz5IkdCmU0d0JVDA1sBZhMAxucQSi+uy+wqSfSQYVs0ch7JjHfgfW/OazAtA3WjGFrvIj6h2ewvFQ9S/tlisxOawYYLF2i+XK6M+1rOrd0Nmabw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFyHjNlHC3AXLwXJTOlDZj0XbxS8K1ytfiHHZ/ZQUDqn3lbS4w9vo9p4PYk1rYh+FZtss0dyZ/pnZr9QMEDO1HExPen/s49Cq3d/BRr5K9Ff5c4kj37sC1FI/lIRphJI5oeGVi51GdJMXc1dAY2dvRAmeb0958LK5CX5Acv+wXzmeFVHXQSz/er0CG+gf01vVVK01abC5TZiY99u5AHXytDn2RfWoKNwQtT/Imb/S5O3cJ6lDY+06NAQSSistmW2JO28GvO8vLqgwcnD5FO5NEfj0f8DWjBweoShgDOAP6/ndSHy6x6rLx8406ANf40yiW0X4G35ZbiI790XyB5L0g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 21 Dec 2021 14:16:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.11.2021 14:39, Anthony PERARD wrote:
> When doing an out-of-tree build, and thus setting VPATH,
> GNU Make 3.81 on Ubuntu Trusty complains about Circular dependency of
> include/Makefile and include/xlat.lst and drop them. The build fails
> later due to headers malformed.

A circular dependency would mean that besides the expected dependency
there is also one of include/Makefile on include/xlat.lst. Where is
that? I'm not aware of anything include/Makefile depends on. Is there
any dependency being introduced in this series, perhaps by way of new
(generated) dependency files? It would be good to have a clear
understanding of the issue - as you describe it, it could as well be
a make flaw.

The adjustments themselves look okay to me, but of course they don't
help readability.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.