[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v8 29/47] build: replace $(BASEDIR) and use $(srctree)
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Dec 2021 15:00:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z+IQehem7mOLSAZ6/KgK8z91BqxQoaUEJU3w7hNuw44=; b=c4wlc11uO9ECvWhZDGsGWe4CyLTsxUeV7M/vxMB9i+/DR84uh/s6aXDdua0xIWTwG03Y84d4+0LKfEkaT5b4dvy5M0rqyM4bh1g4Vh38EhJAnnT/teYc1GaEOtbWfudg/idhcRTmSZnnMVzdK+qV9pRK15/zTVwJ3unXG0bRXWSbVF88Wm1meyBBLLsHTk3Ey/xOr/txKSMQ4mqzIVriBW7B5eWDiKVvIXSIWUaKNK0ViKg0eJKOoK1Ibcdi07lESGe/GdQIgdL/eKw8QrFsf6Xs/PqWPURHl5sP8nTFwNnrSpCXMdiEInZOdEGeYvupdkM3b9H3YcS0Zvckra3zsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWTLWdt8eezFQ/mR32IoxLOywBJnn2oSY39/9misiP6aV5Wh0ve8Ndu1tusBvxqRq+ZRzqZ9nJRSvQHDQJSPMvlD0OojY7KbqDcvVhHUrgOJawLbEoywP7h72m+jGp1p6Pq20+JO34IzrmeoChFujq2pX1JDkOkw36VX74dNy+NPL12JWaePpquOCNIJxj8lBTxpDPNQzQ4XLglyFqAvMl0Kan9w/ElTV1pBDocGIJWP4dI0ht+HRxxpnenewtBCjKyJZGoRVaSkIb24d9tjM8Z2FFmL+v1v+hetmRjPgQAC9IOn9pImw5gCQSBqe+dyo4gAtmC/eeUlofrQZIfAXQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 21 Dec 2021 14:00:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.11.2021 14:39, Anthony PERARD wrote:
> $(srctree) is a better description for the source directory than
> $(BASEDIR) that has been used for both source and build directory
> (which where the same).
>
> This adds $(srctree) to a few path where make's VPATH=$(srctree) won't
> apply. And replace $(BASEDIR) by $(srctree).
>
> Introduce "$(srcdir)" as a shortcut for "$(srctree)/$(src)" as the
> later is used often enough.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
One remark:
> --- a/xen/scripts/Makefile.clean
> +++ b/xen/scripts/Makefile.clean
> @@ -5,9 +5,12 @@
>
> src := $(obj)
>
> +# shortcut for $(srctree)/$(src)
> +srcdir := $(srctree)/$(src)
Might it make sense to generalize the comment to "# shortcuts" right
away, in case further ones appear? There seems little reason to have
the comment duplicate what the assignment actually does.
Jan
|
