[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 16/18] x86: introduce helper for recording degree of contiguity in page tables


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 21 Dec 2021 09:09:45 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+x8nwd/UVS8jAWrbfjVyyVlkE1kxDCyYdnZrzNLbIb0=; b=WfCttmnt5fQreJ6IEmzvIPQUS6bq/JHlz7cc5bP60GRHANhDWcFZCXWwxNshi2RJnPuXeaQHcsHNTxk8RvrkileluD5ihrWLsxocATHyVeIhXUigK+hkU1cNDY5WDK0/UWgpYbinUzNjOLleK4U1BswL+6zvz3Vl4F72nn3kO/idJ3XLOeafl6ghH54GhKA99eBQxL6rhD+YlJRJvYGlhmP14JCV/dVr8AfkVFRDRtmKK8m3cAt4Ombj9B5+Oa7yt7yahr71EY/3198ifdckqroL7ZO+MkNObxeXDMCs6sgz+rxJOoVLIkO6oSbp6rTDyLaALQa4l5vYVcpk1cFiFQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=idDmd6rZe4Qa1m2eUGo36rhGMgCNFVXLre9wq7YFjNYqut3vkbFtsSQVW1k3nd5p4cRadlDDLDnFx1RMSj/x0XKksNKcC+ThCvZaed9QtIjOgCA2YEQLTnOYYohPWoctR+Kf4e4IGwJ51s6jIvwzGTk/vNLUT2iqzhn9tADevPkp0fDozQCwZYz1QC1ZXDeXNQJiIE/kO2/tlKGwUMC/uDvytm52Qd7zzqOesyw2EavzAu8mTKqgt0v6zkCT8fQTQqqSMAvg24TpX8jZVmqluXFc3CF4K5hF+g8/LCkJzAyBh9ugDMy+H+3uD4mRK6LO6Fs4LLxvebp7mz+wMVgzyA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 21 Dec 2021 08:09:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.12.2021 16:25, Roger Pau Monné wrote:
> I think it might be interesting to add some kind of unit testing to
> this code in tools/tests. It's a standalone piece of code that could
> be easily tested for correct functionality. Not that you should do it
> here, in fact it might be interesting for me to do so in order to
> better understand the code.

Actually I developed this by first having a user space app where I could
control insertions / removals from the command line. Only once I had it
working that way was when I converted the helper function to what's now
in this header. But that user space app wouldn't directly lend itself to
become an element under tools/tests/, I'm afraid.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.