[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 03/11] xen/arm: avoid setting XEN_DOMCTL_CDF_iommu when IOMMU off


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <julien@xxxxxxx>
  • From: Penny Zheng <penny.zheng@xxxxxxx>
  • Date: Mon, 20 Dec 2021 05:21:15 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tJcd0gELplO85ZW04E9W1750ifu69iwOym9xLUkG6o0=; b=jZfXI7sb4f1fQVJnyK+w7FjGVnJQgZKEDEA/t0sWliqBI2KE6wasT/8ouksVfnY/+qchWkhYA//fZagj7cxdpVT0qdvrY1nikVSEGB6UQJ6eRVaLi2+wk1xSlad6cfAgdiuGdKqt8BLeDJNuswAMj4xRzl32N7csplQZ92wnV4ylLB1uOG672Lngd6rd4yQA09c/B4bvIT3s+mxhZwLFZUZYMpmjVa2Td/qWHTgsyPYn32SC/SfvbFemP6pIOYCSuRz8DgaCJPieN3Gl31/LkEr4GAagEB/n4WZuKvxiZ5gfdidYSlXMW5PiAe24kq7UOdSStCWherl3Jl4wkPOw/w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Np0BPpnXvpx8yKQ/ZlcSWHAuDhL76qXAh8d+YdtKPpJfWQEwy8tRiSHvJMFMQRNwWQSc5p8ViTxpCRJJJKSRb4047/H246KLqfW46uUqrTYFkKV9+Kn/c7BIDD33jguSP5qLRrtHU2QsQaBSQzC8TeaXZqpSccVWB7Oc0+TxO5nuEqD+tGlxV0aQya5FHvUrz+eOlhVfsPOxKpD+jVEgrlRnMbys6vlXBGITgIb1gXAyRlh0GfTUXvCyXiTN2phOH05h+Rfxpn9+KuEDBXgOmaWJtTLwJER+Wep/BFLSBmdQ5uO3fqy2zcKT2gEPAGG3g8E7mVUcUghBzPYMSHCmlw==
  • Cc: <Bertrand.Marquis@xxxxxxx>, <Wei.Chen@xxxxxxx>
  • Delivery-date: Mon, 20 Dec 2021 05:22:27 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true

From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>

When IOMMU is absent or shall not be used (trusted domain, performance,
hardware limitation, ..., etc), in which cases this commit avoids setting
XEN_DOMCTL_CDF_iommu to make those user cases possible and prevent failure
later during device assignment.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
---
v3 changes:
- new commit, split from the original "[PATCH v2 2/6] xen/arm: introduce
direct-map for domUs"
---
v4 changes
- explain briefly in the commit message why we want to do device assignment
without IOMMU.
---
 xen/arch/arm/domain_build.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 9b1a5e38d3..5a106a977c 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -3047,7 +3047,8 @@ void __init create_domUs(void)
             panic("Missing property 'cpus' for domain %s\n",
                   dt_node_name(node));
 
-        if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") )
+        if ( dt_find_compatible_node(node, NULL, "multiboot,device-tree") &&
+             iommu_enabled )
             d_cfg.flags |= XEN_DOMCTL_CDF_iommu;
 
         if ( !dt_property_read_u32(node, "nr_spis", &d_cfg.arch.nr_spis) )
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.