[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform


  • To: Julien Grall <julien@xxxxxxx>
  • From: Oleksii Moisieiev <Oleksii_Moisieiev@xxxxxxxx>
  • Date: Fri, 17 Dec 2021 10:48:51 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P6v4UI4Sdb8ZSGPH0XO3ltm2HNG6ZO4ThTLPKFRcAUo=; b=JwLI4rckJhsgpMmgrvm70NPqfHEdE1Hvr8BJdFR9FmQsF4hVAAoWzv2SpmrAcWSTYYo4CdU2WH24Ertk0XLsbPyL7ZJ5ksSy3mAM90T6wkmhdIIBfGfYpExEFR9J89h9wkesGGOBPulquHvEkSgHHcQzb377p7BIdNB+DHVjCB/Hrw4MpMQgHzwSgPguVvFr8e2VI4mTzcpM+TcKJI5CF9pVKe6o7ci6CxCV2prEbTgnM6TQiHsKnoLeGpkrtOUjIyXcyCBcOoyAZ9a5TOEQ7cbDxZuH1QHPT+jU0dGHHTD11ynF91ZQNm+J9yGLxczwkvsKyeJKGSntXnQh6+x9Yg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pl+lIYrjntDrXMCkXShiqa1Ok4jnp4pvtCycccPPK2e9noGyI2Ijb2EkVH7AIjj5qdh52GjISoQYOxvOnbYnXI7AygVdKdzHAXW6Q3NIb8fmC9xkLE9B2W9pzwNAr3PoPTXFJ1j5ZX/hF4IxKS00fBodCjSBDURLRKm5jtnb3eaqgM9OesvwFTMk6lX279pUc75Qc4SQ9MoK3ugm88mycnpTq3S9ng+nQuNRdDLRhw0obVKNXdmBYBD4gRux86sV5f+4i3AIJUdnm75m88OOlJXJg/eN3cNNMrQSTIJnfgGEtHaQQkOOEgcOUut82TSgpnL2Asa1i2EfizmKAceeIA==
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
  • Delivery-date: Fri, 17 Dec 2021 10:49:11 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHX8M3HLq8qFfw2eU2jxqbriRiMpawzTbcAgAM4BwA=
  • Thread-topic: [RFC v1 1/5] xen/arm: add support for Renesas R-Car Gen3 platform

Hi Julien,

On Wed, Dec 15, 2021 at 09:39:32AM +0000, Julien Grall wrote:
> Hi,
> 
> Looking at the rest of the series, this is going to be replaced in patch #2
> with:
> 
> return sci_handle_call();
> 
> SCMI is not specific to RCAR3. So I would expect the function to be called
> from common code.
> 
> If it still needs some platform specific code, then I think it would be best
> to introduce rcar3.c at the end of the series. So we don't introduce a dummy
> platform and not hook the code in the middle of patch#2 which is meant to be
> generic.
> 
> I will have a proper review of the rest of the series in the new year.
> 
> Cheers,
> 
> -- 
> Julien Grall

That's sound reasonable. My first thought was to move SCM func_id to the
different section, such as Arm Architecture Service (see Section 6
of DEN0028D). But I think that SiP service func_id fits best in this
case because from guest standpoint all clocks\resets\power-domain ids
are SoC implementation specific.

I'm going to leave SMC func_id in SiP range, but refactor SIP smc
handler, so no RCAR3 specific code will be needed. So there will be no
need to introduce rcar3.c in this patch series.

What do you think about that? 

Best regards,
Oleksii.


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.