[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for hardware domain
- To: Julien Grall <julien@xxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Fri, 10 Dec 2021 18:37:20 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBMrnK8FE5UpZd3amEKKd2tlKe96FYPd0Mksfq8EJRg=; b=h2qqwfRidIojbeqJ5GoDDZoeMC8pNqk1C09oFNOrFywt3ZljPqOCY4B1dstXpBqo3jDqc271B1vMHZlJOaJT7OV8nKdgfHlFDOO220bdCjHLzozf1RwxDeOE6rAcj3UElm1zm9VlhaZCEBfKj13anV+JzruGWJ44vjKWZwwJKrtmbu8GCjp+21poFDWEmGwbJ0rU/kajVx/RsWgg7kVuH01suHJ4QEmHwI83PQRo5Ug74dY05Rdn+PgJVxSv3hoJmVWlYZBKxH1zeGh8wLOCnViLnRCI84fV0CDVR/mxJ0FX7xy3wxbv4NFzRutQWkd6hIw2j0lkDcP34Tg0QOz1bA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O/EWCPTZdlI54PT/IcMdW08sp8FNVpjFWY1WfR9gCSJ9KS710uRT9yqYTknUg1Oh7zX00fXNQEqFwnEnm8YjMT0UrY48w6hAsQsN7cTrM3/DyP/TNXRKiADc9XKbpoU4620RqyF5RDdBJLAwaEEet0mtt+Lr1pTW2njFDoDFuGK7OBP7C+y2wp/0WMxxrkSPIQOyuUoq63TTtFUVcYusCYIPcUwiPgwH5MD5J1TTkXxl27m9V5Fwfn4iqcw7Jat5p/PDizvi1o6S+zTuib7yZLckMpj+rV6Xggq+0Yddxu7wPKjMpaJgzNI+8Un+dAQlvrpfSIThp4ggmWvvcKGLqA==
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>
- Delivery-date: Fri, 10 Dec 2021 18:37:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHX7M6BKfC+NnP8FUmShHJlmPRsZqwsA82AgAAMgoA=
- Thread-topic: [PATCH v8 2/4] xen/arm: setup MMIO range trap handlers for hardware domain
Hi, Julien!
On 10.12.21 19:52, Julien Grall wrote:
> Hi Oleksandr,
>
> On 09/12/2021 07:29, Oleksandr Andrushchenko wrote:
>> +unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d)
>> +{
>> + if ( !has_vpci(d) )
>> + return 0;
>> +
>> + if ( is_hardware_domain(d) )
>> + {
>> + int ret = pci_host_iterate_bridges_and_count(d,
>> vpci_get_num_handlers_cb);
>> +
>> + return ret < 0 ? 0 : ret;
>
> Sorry I only spotted this now. AFAICT, ret is not meant to return ret < 0 in
> this case. But if it were then I think it would be wrong to continue as
> nothing happened because the code will likely fall over/crash when
> registering the I/O handlers.
>
> I would document this oddity with
>
> if ( ret < 0 )
> {
> ASSERT_UNREACHABLE();
> return 0;
> }
>
> I can do the change on commit if the others are happy with it.
Yes, please, do me a favor
>
> Cheers,
>
Thank you,
Oleksandr
|
