[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] IOMMU/x86: disallow device assignment to PoD guests


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 9 Dec 2021 11:04:36 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IQJolgPx58vBCP3gruV/auBd7uHNx7OWlDec7UmJ8v8=; b=n8eibC8MytqlfFN9SrGYe9tdvLAy/XUxgDllxb6Os1FrHGukiaE/hvhyeBKl66FH/p15UzPAW3y1NwfdiluQ90prwP9GCWgoEKGCB5K9zVVYx+glqsyaMnDXrjKWfpnyjA/LNSHJ2IL6q8deiHVLGIAcE0wAEKKpNUmkFHpS9fnYgBnnY//oBI0lQTUKnrHpfWWIjFc3Zcp/7NfkFVI2lvRoZ2FqiKlXxEu0fTvJ+kej/FDJXfRbh38Fp9Qcqf/SeFU7Cxx00nLAKOj0i/AawyZGxiABCqzotfOXRzfNm8dJ7EFY2S/b3ORKKlDtRYYuFkG/SFZrqogdPvxVBTLtPw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UuVTTgQwCF7OIjZrYAbQR2mQweMVkKIZj6w+IcNcf2E7xnu1jd4hzbIpj4fxcaOZrIEDbzb0nKooC7Hq3gTe7AyQkTeVFo0jWnuFIt1olq/XjqNbRAiNyT3okYYyCjuOQRJt9UyUz0BB5BkdkHfShkUfyWhTOLLpMaH0TK5ILK0Z/tJ5aKuj9vsBM5TgHTQvfH6brJsIKOy53aqWR8Pu3psquYim0DdVFyiGMv0UovtvKkBRtCKV9uU4UEiPQM3QD830LURy/Zfc7KBS0QxyW0bRUXWK6TFV+GnlxehVAn/6bIcRC2nAqrs0+1V+wREqE9UroPPPb+6UBsmQvxv4VQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 09 Dec 2021 10:05:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.12.2021 12:20, Jan Beulich wrote:
> @@ -333,6 +334,9 @@ p2m_pod_set_mem_target(struct domain *d,
>      int ret = 0;
>      unsigned long populated, pod_target;
>  
> +    if ( has_arch_pdevs(d) || cache_flush_permitted(d) )
> +        return -ENOTEMPTY;

This breaks toolstack based ballooning of PVH Dom0. While I question
the invocation of set_pod_target in that case, for v3 I'm moving the
check down to near the end of the function.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.