Re: [patch V2 08/23] PCI/sysfs: Use pci_irq_vector()

[Bjorn Helgaas <helgaas@xxxxxxxxxx>]

On Mon, Dec 06, 2021 at 11:27:36PM +0100, Thomas Gleixner wrote:
> instead of fiddling with msi descriptors.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Tested-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

s/msi/MSI/ above if you have a chance.  Nice cleanup, thanks!

> ---
>  drivers/pci/pci-sysfs.c |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> --- a/drivers/pci/pci-sysfs.c
> +++ b/drivers/pci/pci-sysfs.c
> @@ -62,11 +62,8 @@ static ssize_t irq_show(struct device *d
>        * For MSI, show the first MSI IRQ; for all other cases including
>        * MSI-X, show the legacy INTx IRQ.
>        */
> -     if (pdev->msi_enabled) {
> -             struct msi_desc *desc = first_pci_msi_entry(pdev);
> -
> -             return sysfs_emit(buf, "%u\n", desc->irq);
> -     }
> +     if (pdev->msi_enabled)
> +             return sysfs_emit(buf, "%u\n", pci_irq_vector(pdev, 0));
>  #endif
>  
>       return sysfs_emit(buf, "%u\n", pdev->irq);
>