Re: [PATCH] xen/arm: Do not include in the image functions...

[Julien Grall <julien@xxxxxxx>]

Hi,

On 07/12/2021 07:10, Michal Orzel wrote:
> On 06.12.2021 17:40, Julien Grall wrote:
> > On 06/12/2021 15:00, Michal Orzel wrote:
> > > Hi Julien,
> > Hi Michal,
> >
> > > On 06.12.2021 15:39, Julien Grall wrote:
> > > > Hi Michal,
> > > >
> > > > On 06/12/2021 14:19, Michal Orzel wrote:
> > > > > vtimer_update_irqs, vtimer_update_irq and vcpu_update_evtchn_irq if
> > > > > CONFIG_NEW_VGIC is not set.
> > > > >
> > > > > enter_hypervisor_from_guest is protecting calls to these functions
> > > > > with CONFIG_NEW_VGIC but their definitions and declarations are not > 
> > > > > protected. This means that we are including them in the image even
> > > > > though we are not making use of them. Fix that.
> > > > While I agree, they are only used by the new vGIC, the implementation of the 
> > > > functions are not. So I don't think they should be protected by CONFIG_NEW_VGIC.
> > > >
> > > > Actually, I am not convinced they should be protected. But I guess you did that 
> > > > for a reason. Would you be able to clarify what is your reason?
> > >   From what I know + what the commit introducing these fucntions states 
> > > (b9db96f71a74), the current vGIC does not handle level-triggered vIRQs.
> > > The functionality of these functions is only related to new VGIC implementation 
> > > which can handle level triggered vIRQs.
> > This is a known error in the vGIC implementation which should be resolved 
> > before this leads to a disaster.
> I just thought that if this error is present for such a long time, there are no 
> plans to make current vgic handle level type irqs.
The error has been present for such a long time because no-one yet 
volunteered to properly fix it. That said, the new vGIC has been an 
attempt to resolve it but the effort kind of died.
It would be nice to revive the effort.

Cheers,

--
Julien Grall