[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/7] xz: add fall-through comments to a switch statement
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 7 Dec 2021 15:56:29 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fesGwMC+sgklS9IYU5JfH8dnwTc+ryP7uhzAVm4VrBM=; b=AVN9xqr090pgD+Oori6XMy/Z57VlKPMiu3ClXZbzwa3DGPBSxgD6+gkLCwGxsi4BQqHzSVndkPs/1OmFZjcxfeGLyiPuhueUvSd3MtuOt1URRRvd8HbEWjuQjoe1aegouUeogk1ldjtlkk+iRGUP5LkWAdQVkTSWqI4vTsC1pKCr3Rf+CZeI3O3Gsg20AyEeGaxi3C1GVSqpG+Fsb1i35jXnr1ELklK3JnCpjxWUhw0Ekj+ox2aoxk3JB1YLiP3GUPHLqWm+W8oo9ooDtaMeFFEzALY6BH8QfHjVfVQm1G5SyNmFS9DmIDsIX7eztxbc6fv5i1VoOSlCVOXU+KPfJw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HFYjWh5OAy7LDAZiSpisK4OdtKiO4uHV8jMFo38pLdyriA759WD3n8zNS1+OKZ8tH4EKQxRciISBV5qBTIWgn1rvPOIHwxQv8yicgAoaoMEcH67S/p4l5zqUDy50fXowllae0zPYev1D3v3BWoPnaVGVk7GTUN5+dQqIuHD981hufQVtzLaJBvUq0VqIWFqOnLutBAm+72C4q3iwmk/4wWQjNkvtoEK1vmTQJTawuRk7swZ7mN3pxc2tPPHq1bGFqHQ0aC4MT1JD01+Oq0OQNdLxrOjOwBIQWoW5SSixIq9hwzIfur8O7mg77w5W/LTaUVpfxlr2sxIy2gNtTkuTRg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 07 Dec 2021 14:56:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.12.2021 14:30, Jan Beulich wrote:
> From: Lasse Collin <lasse.collin@xxxxxxxxxxx>
>
> It's good style. I was also told that GCC 7 is more strict and might
> give a warning when such comments are missing.
>
> Suggested-by: Andrei Borzenkov <arvidjaar@xxxxxxxxx>
> Signed-off-by: Lasse Collin <lasse.collin@xxxxxxxxxxx>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
> [Linux commit: 5a244f48ecbbd03a11eb84819c5c599db81823ee]
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
Because of the ongoing discussion on the respective v1 sub-thread I
have dropped this ack. It was suggested that I may have misunderstood
and it was actually withdrawn.
Jan
|
