[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch V2 18/36] genirq/msi: Add msi_device_data::properties
- To: Cédric Le Goater <clg@xxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>
- From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
- Date: Tue, 07 Dec 2021 13:47:37 +0100
- Cc: Bjorn Helgaas <helgaas@xxxxxxxxxx>, Marc Zygnier <maz@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxx>, Megha Dey <megha.dey@xxxxxxxxx>, Ashok Raj <ashok.raj@xxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Santosh Shilimkar <ssantosh@xxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, Stuart Yoder <stuyoder@xxxxxxxxx>, Laurentiu Tudor <laurentiu.tudor@xxxxxxx>, Nishanth Menon <nm@xxxxxx>, Tero Kristo <kristo@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Vinod Koul <vkoul@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Sinan Kaya <okaya@xxxxxxxxxx>
- Delivery-date: Tue, 07 Dec 2021 12:47:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Dec 07 2021 at 10:04, Cédric Le Goater wrote:
>> +/**
>> + * msi_device_set_properties - Set device specific MSI properties
>> + * @dev: Pointer to the device which is queried
>> + * @prop: Properties to set
>> + */
>> +void msi_device_set_properties(struct device *dev, unsigned long prop)
>> +{
>> + if (WARN_ON_ONCE(!dev->msi.data))
>> + return ;
>> + dev->msi.data->properties = 0;
> It would work better if the prop variable was used instead of 0.
>
> With that fixed,
Indeed. Copy & pasta w/o brain usage ...
|
