[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v8 04/47] build: set XEN_BUILD_EFI earlier


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 7 Dec 2021 12:24:34 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AV4SpssrYaGyn0sCUuJtrY1jLEs20ZCGEia+x8rkXlI=; b=euzjQm29jaNEjkEnvlC4290ed8A1deEEkPy+pD225n7+hAkhflvPCUFyu8LydbU4d3i0g4QXexsulii4f2I1XoOoNiTz32N5WJ3r5BHeqvr+CjUA/48/Xlf7J00BvFHtwM7OicwADdwwbgmjqQ0T/bjCB/CiMqHit1nrYoDgJV/EJnKU2OzEFaJSqf3vOtbig6rJH29phrWw8K+Cya5BF4p8W9cogBn6bPV0n3eqkqIztXFW/jZpagH0daF0wshwvNzKW5AhZZzbBuzJrJ8PE1vEnVzBS0OaXFmzyaiQRl0kHsdcddlPVDkTHVjdHUNFTfBGrjJs6HmMkZgGse7Syg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JpZ4bMP2bMN0ApBx17sYgzlbBQCHFainUrfkEM48oVn4KHdNxCxZBYcoqXiFPxw7R8K6U/gLgj10qYWlweBO8To3r6+R8+pZyG36//dRtunC3T2Cyy4FJzbBpaOpH3E9qa3bxn3WtMBSBK59jDVaBqCZBjQBP779XtKeKECCQHYDO0h/UG1+VT+SHtmtipgBw0RiOmrW1OAXwufT2GXANso32CmS6wfN4uZiAVvLH6wmZx7ogRUVPHX61fLswN8N2JG4TakNmnbmm4cBaKc1TsaHO64+KeuyMBkQerIZestjr51X4p0/BDdq/vQiETQ0YNIKsE4mKAIIWquk3y2DUg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 07 Dec 2021 11:24:47 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.12.2021 12:04, Anthony PERARD wrote:
> On Thu, Dec 02, 2021 at 03:06:54PM +0100, Jan Beulich wrote:
>> On 25.11.2021 14:39, Anthony PERARD wrote:
>>> +export XEN_BUILD_EFI XEN_BUILD_PE MKRELOC
>>> +export EFI_LDFLAGS
>>> +endif
>>
>> Exporting MKRELOC in particular isn't very nice. I wonder whether there
>> wouldn't be a way to keep it local to xen/Makefile.
> 
> I don't think that's possible. The value of MKRELOC depends on a call
> with OBJDUMP which depends on call with LD which depends on a call with
> CC. And the call with CC is the one I'm trying to move.

Like suggested for another variable elsewhere, besides moving the definition
(which I agree looks difficult to achieve) there's also the option of passing
it on the command line to (presumably) just the single sub-make which
actually means to consume it. It's only the final linking step where it's
needed afaict.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.