[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch V2 22/36] genirq/msi: Use device MSI properties



instead of fiddling with MSI descriptors.

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
---
 kernel/irq/msi.c |   17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -122,21 +122,8 @@ int msi_setup_device_data(struct device
 static ssize_t msi_mode_show(struct device *dev, struct device_attribute *attr,
                             char *buf)
 {
-       struct msi_desc *entry;
-       bool is_msix = false;
-       unsigned long irq;
-       int retval;
-
-       retval = kstrtoul(attr->attr.name, 10, &irq);
-       if (retval)
-               return retval;
-
-       entry = irq_get_msi_desc(irq);
-       if (!entry)
-               return -ENODEV;
-
-       if (dev_is_pci(dev))
-               is_msix = entry->pci.msi_attrib.is_msix;
+       /* MSI vs. MSIX is per device not per interrupt */
+       bool is_msix = msi_device_has_property(dev, MSI_PROP_PCI_MSIX);
 
        return sysfs_emit(buf, "%s\n", is_msix ? "msix" : "msi");
 }




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.