[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v8 09/47] build: rework test/livepatch/Makefile


  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 6 Dec 2021 18:00:01 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ro03WXeRgue+HJrGelJsql20dtKmvllsT2bxUS+wI1M=; b=Isge1wsacaziFZFqG7Pd4787XJps58ec+V334Sbejd/IWv4TVzpvKuOu829jQMxlXiSlheGzsfR41tTAdLuUT+Wwz9qAvdASVf3R0udNYjS/RrK/g9OOzuvcLidzfNKwYSkrFtt/RgbXPuaBYiy2IQidqB9Qyo/MjdullflSHGVhJ7tdFJdAn4ktoLP76vITi6HsY2cpMRTAemA4JND814Xi6N8Xa8vfECnC6obkTULcQirjHY86UXDFw944XjLwBd48bG+kDgYKiLx5yxn2trimEasRTFkOiDW29qSL9133jWzg6Ewx/5u6aTsyGuvESTuYXZjucYDNKaQZczxdTA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OeJJ+BWQRZE+sjP94ElvuX1fcURn9lFUigDgurBHURTZrOGW2z+6VTDkhZT9m/9HnHSAHWhcqBCCem9KYreDDe/wDbBbjfCXhPWqmi6W1oe8rMpLcQDYl0c0sMofxGlcNVudG1dct0VCiTP3PwUE+g5eQ9x4VdF3brNYEM+u2t08sYu7akkMGk74KBiapNBcQAXlCXY+2ORThHHwiJcxvTm/bufyoYpL3Wg84FsBbAvKGEXztKT1mXV+YL30FotdcEeFiO/5ddIz7d+pWhrvyZlD/S6DXTHZ7uIV4SVZbke97CL59NFO3OtSDpTTe/+A7pXLHFBrtUo56iust447SQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 06 Dec 2021 17:00:23 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25.11.2021 14:39, Anthony PERARD wrote:
> This rework the livepatch/Makefile to make it less repetitive and make
> use of the facilities. All the targets to be built are now listed in
> $(extra-y) which will allow Rules.mk to build them without the need of
> a local target in a future patch.
> 
> There are some changes/fixes in this patch:
> - when "xen-syms" is used for a target, it is added to the dependency
>   list of the target, which allow to rebuild the target when xen-syms
>   changes. But if "xen-syms" is missing, make simply fails.
> - modinfo.o wasn't removing it's $@.bin file like the other targets,
>   this is now done.
> - The command to build *.livepatch targets as been fixed to use
>   $(XEN_LDFLAGS) rather than just $(LDFLAGS) which is a fallout from
>   2740d96efdd3 ("xen/build: have the root Makefile generates the
>   CFLAGS")
> 
> make will findout the dependencies of the *.livepatch files and thus
> what to built by "looking" at the objects listed in the *-objs
> variables. The actual dependencies is generated by the new
> "multi-depend" macro.
> 
> "$(targets)" needs to be updated with the objects listed in the
> different *-objs variables to allow make to load the .*.cmd dependency
> files.
> 
> This patch copies the macro "multi_depend" from Linux 5.12, and rename
> it to "multi-depend".
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> 
> Notes:
>     v8:
>     - rename multi_depend to multi-depend
>     - use $() for single-letter make variable
>     - re-indent one line
> 
>  xen/scripts/Kbuild.include  |   9 ++
>  xen/test/livepatch/Makefile | 213 ++++++++++++++----------------------
>  2 files changed, 91 insertions(+), 131 deletions(-)

The tiny non-livepatch part
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.