[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
- To: Luca Fancellu <luca.fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 6 Dec 2021 08:27:18 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A+9MgHcc47O3DL0m+Q3Hvp3+k3MJhtMIN8Toor36pMA=; b=cR3H2y++6Odz0lqYnaAMfyaxPZ5ARgJtCoAKeUzT8Msm0JIfbHpXe9BOEDXhHS/IvpzuK84Rs1d8Wt1uYd66Dpi2RQvxATf80RN/9HC4nglCUcYsG8SWjzxhyVOab5sxmuRvQyGI7EFAazZhw6tj2yeQsXeaCgykyOpHzQfBbJJwCDwg2O2JuL3sza6qfwCE2ltsjOzpa8Qfn7FlRuEHQBsZC/CtxBPmh0gW4ZeF9Ox46HT/YK5mKKJc74TzTceXK0EQgheYlohH5lADcPqDdeAaXzTenw0znk+K0AYgk0Z+Bhk1MQ2DkuLnjyin/z5gi8VYaLBEpIUOhLvSQQbPGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TmNVKz5jFrTP+lcGqaTIqkxdSbx+nbF8aDh0nOQgJN5N/cObVdLHEasEd2L9inpmyVoV83sHMOmvHFWeGMk6vLWngHOA2lPsZtlSljs0kqQChgs+E402PL7H3pw42QDeU9y+1rqp+PMEevBpCeTc19rCtfJGgyeOCNZ/93JXIyvg9z93l4wbT9o0Ofa2fz5O4dfnyK9bXzTbI/cowL+TH38Vx7YPCOHlnqKrRz6VxC6vzvprJI/6LAKGSM28Fo+r/0lWrHio3WzfQ1d2uWEj/XTOSey1y05iblI7WLzBcLCOTVaWWNMJ5EvH2lxbx7G+QkUZ3O2tMxxp0mV8tY1COg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 06 Dec 2021 07:27:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.12.2021 17:10, Luca Fancellu wrote:
>> On 3 Dec 2021, at 10:56, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>
>> When it was introduced, it was imo placed way too high up, making it
>> necessary to forward-declare way too many static functions. Move it down
>> together with
>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>> immediately ahead of the #include,
>> - blexit(), because of its use of the efi_arch_blexit() hook.
>> Move up get_value() and set_color() to before the inclusion so their
>> forward declarations can also be zapped.
>>
>
> With the “const” attribute now some function in this serie are above the char
> line
> limit, however everything looks fine.
I wonder which part of this patch you're referring to. I don't recall any
addition of const here - I think I'm strictly only moving code around some
code and delete some declarations. I've further checked the code being
moved, and I couldn't spot any line going beyond 80 chars.
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Thanks.
Jan
|
