[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point


  • To: Andrew Cooper <amc96@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 3 Dec 2021 13:50:32 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KrPc8cD+EJ8zaFM/6eDcq7gpUw2conBGCQOsCRVdOrY=; b=KnpdIX9uLkvCTRrvIav5axOrtCPwz0rkCDv/MGxfxSST+KQEEKLYTVyVDHuRT074TJtiorwhAux3BIaF7HRIYAZLFn0L3NEz3gxdwtdvmnTkFQOM4VbgdrX87niNjsv0wPzVebRrfRBG65FtIKi8QtkerCwBGUF+XMYKEvQQIGijDyUpE8JSyYzy1TbGDztte7WJ8tVabDFmtkC2/3nGqlJKN8uhYpUuWf2OcDusToKpwOmO6/3JRFaU0enxw5E1JnIxHC9FjxuUu+to5b1YF6hWi/k6kCb6+5xyEkoowU4F4Jfl5UO+L2bxHDjFUd5uPsHGj3joRr8lywtgvU3bzg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q9t2NSFq11pJiWzKlqxf4USQJ5Ad7Xw+u9nhDRfAZ2x0f7bo4n5P3YpDy1wduyMbudScwjNyEzTuyd+oLd9h31ykaaEEdU4fXlZRfe/gGTle8CPJl2qhfXD2hSV+EuwLITAO7ZLpvz0ZmqJOqmZWFl/A4ZpNXjAsgmQ1MLuj+GRpBbJ8D2QVPmax2B3Te9Qy2vtjxQ/sr4t2VRg+17m2DFA0ZO8dQT9U3iETZ1gkYlz9FNiRaxiMEQmjwEE3z0nBseIJyS+DqMdKMX7w6J5nulpIZ7p/vziMv3w3cC2NlLEGSAtA/oNocwCT+7v3dZSw+QlY7f2W5qrwJgMliANU5w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 03 Dec 2021 12:50:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 03.12.2021 12:21, Andrew Cooper wrote:
> On 03/12/2021 10:56, Jan Beulich wrote:
>> When it was introduced, it was imo placed way too high up, making it
>> necessary to forward-declare way too many static functions. Move it down
>> together with
>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>   immediately ahead of the #include,
>> - blexit(), because of its use of the efi_arch_blexit() hook.
>> Move up get_value() and set_color() to before the inclusion so their
>> forward declarations can also be zapped.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Why does blexit() need moving?  It isn't static, and has a real
> prototype in efi.h

Correct, but the movement is for the functions it uses from efi-boot.h:
efi_arch_halt() and efi_arch_blexit() at least (which actually the
commit message also says, for one of the two at least).

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.