[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] arm/vgic: Fix reference to a non-existing function


  • To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>
  • From: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>
  • Date: Fri, 3 Dec 2021 11:23:36 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=arm.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mvlwS1dvBlnlZTr3CCWS9Qgh2Tyhuiho/pCIHihSSno=; b=eDG/Z82nmRPO8bcehmmxdfobV6L+Vf3GlmIf1z5ikERR02pDCPB8de5wQVNXxuWvusPxcs4kXGYr1rjMqYUyZIGgo7lTS7srKiIh+X771NnPxkMHM1TCFpTYnLp0j/vWNxgfFsoKBWkixoZieWWrvk7KkcTwq+vKorXecFn7U54q+RNGuIfZ8jHAK20Nv7RauG/dbYclYW97BNA3Yu4XirrcL5tCOmhGSouOvjfiB27GEBVj8DldkJe0vUB8dxRI6Xgh78i+3yA4usH6B8zA+OdNoNcP/l7To8PEWneHrTrZZUEh2heHUziOR6cDKBhChYqRrGWVDN5AloX/UJcXuA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CbJiamsWfrhX0amJuPVVirEfbbEGCLJ3/6sIoL4RkRKrHR98Ez9u2RjcBivGBhuFlJZmD9jW967LTL4H6GwQUJQCjF8TdjkFNA5Vm63DJOzOJuVrq5zky8ttWEDuwzw9y5SxRzThcHXvQVJhDmqPgbWX/2XTijHQJoaMJjxwsaOW0qjyMW9DtrOF6k8dysbuXYCvU+j42fzqf9LVYBSvhmt2kqrN1fkOWpyNL7TEsvi5n50xmGlpLF6mt77A+L75t5xo1rpf36WcOY7re5/U1E5Z8ja1FgM1NANV8W9J2Cqo3woMplsNZw4/oAjQ7WiguQ9V7FuxHNxjnL00C4jFqA==
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 03 Dec 2021 11:27:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>



On 03/12/2021 10:19, Bertrand Marquis wrote:
Hi Michal,

On 3 Dec 2021, at 09:58, Michal Orzel <Michal.Orzel@xxxxxxx> wrote:

Commit 68dcdf942326ad90ca527831afbee9cd4a867f84
(xen/arm: s/gic_set_guest_irq/gic_raise_guest_irq)
forgot to modify a comment about lr_pending list,
referring to a function that has been renamed.
Fix that.

Fixes: 68dcdf942326ad90ca527831afbee9cd4a867f84
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

Bertrand is very fast. :D.
I wanted to check if it is ok to add my R-b.

Thanks for that

Cheers
Bertrand

---
xen/include/asm-arm/vgic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
index e69a59063a..ade427a808 100644
--- a/xen/include/asm-arm/vgic.h
+++ b/xen/include/asm-arm/vgic.h
@@ -195,7 +195,7 @@ struct vgic_cpu {
      * corresponding LR it is also removed from this list. */
     struct list_head inflight_irqs;
     /* lr_pending is used to queue IRQs (struct pending_irq) that the
-     * vgic tried to inject in the guest (calling gic_set_guest_irq) but
+     * vgic tried to inject in the guest (calling gic_raise_guest_irq) but
      * no LRs were available at the time.
      * As soon as an LR is freed we remove the first IRQ from this
      * list and write it to the LR register.
--
2.29.0






 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.