[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
- To: Andrew Cooper <amc96@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 3 Dec 2021 12:25:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OcG6n8Inaqi+6Glj4y9+FfnxSpvy+Xiyjo8nlMWC198=; b=UT1yTV8Y3Bi9hCTT/bIkORorjjRdJZ4A7wtRDEHXB64aVen06RpMb6PLrrospFfjNk8NouEr3FY7M0oSyUwe7XODSTFcr9kwNT5vMaBocRczqhvbHlziiHKu2Dzd/XJXn5fVisttcCNNVE6mYoL6ptEHXr0CRF+dd2aPKZN6SxM/RXXGwNLlQFhRAgYskylpWp4vOSkWIz8AqjXY8pPO8bGHoiRFBp/pNcNBoNeDoqhsjayhvqaG6RsoECs+APnkB7YUwc/xqfih7K1rtmdPU1iLpOKu7vt02239FXzTb//O4y2hH62aX4+iQUkaCv+i+eSCSe88NANeqLOuECYV+Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FUofhmL8p4U9VS6pWFl5oGzXMn7KB9WgqGCJVZ2r6D0FN7U580ak9rgm9WmRO0o/LKhiwAKKJgSOh/Sa+47AUWqJVG51WQZsuxvcgtWnf8Lji0lzoWbi1uw9/jOVwv6I1hnEYnCXHe3dOzOITesKUTYXMI94A+iHHeYVKpZWgJ3KQMIZAz7R0/zUi0+9vXxA/Bdo/hmAqmPu1p6NhU3F7KsHh4nmTSResPciPwvXD0Jav3T3kWUMZ+wqeikyXi2lwiVDtgLs4v5zqSO6cgfU4msqb10BFMearyIfnyLVvnnHcAX6/PB0TyfCLf71ihmHCr+xTyXNllRzSMNu1HS4/Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 03 Dec 2021 11:25:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 03.12.2021 12:21, Andrew Cooper wrote:
> On 03/12/2021 10:56, Jan Beulich wrote:
>> When it was introduced, it was imo placed way too high up, making it
>> necessary to forward-declare way too many static functions. Move it down
>> together with
>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>> immediately ahead of the #include,
>> - blexit(), because of its use of the efi_arch_blexit() hook.
>> Move up get_value() and set_color() to before the inclusion so their
>> forward declarations can also be zapped.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Why does blexit() need moving? It isn't static, and has a real
> prototype in efi.h
Oops - clearly an oversight of mine.
Jan
|
