Re: [PATCH v2 0/6] aio-posix: split poll check from ready handler

[Stefan Hajnoczi <stefanha@xxxxxxxxxx>]

On Thu, Dec 02, 2021 at 03:49:08PM +0000, Richard W.M. Jones wrote:
> 
> Not sure if this is related, but builds are failing with:
> 
> FAILED: libblockdev.fa.p/block_export_fuse.c.o 
> cc -m64 -mcx16 -Ilibblockdev.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader 
> -I/usr/include/fuse3 -I/usr/include/p11-kit-1 -I/usr/include/glib-2.0 
> -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-4 
> -fdiagnostics-color=auto -Wall -Winvalid-pch -std=gnu11 -O2 -g -isystem 
> /home/rjones/d/qemu/linux-headers -isystem linux-headers -iquote . -iquote 
> /home/rjones/d/qemu -iquote /home/rjones/d/qemu/include -iquote 
> /home/rjones/d/qemu/disas/libvixl -iquote /home/rjones/d/qemu/tcg/i386 
> -pthread -DSTAP_SDT_V2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE 
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes 
> -Wredundant-decls -Wundef -Wwrite-strings -Wmissing-prototypes 
> -fno-strict-aliasing -fno-common -fwrapv -Wold-style-declaration 
> -Wold-style-definition -Wtype-limits -Wformat-security -Wformat-y2k 
> -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs -Wendif-labels 
> -Wexpansion-to-defined -Wimplicit-fallthrough=2 -Wno-missing-include-dirs 
> -Wno-shift-negative-value -Wno-psabi -fstack-protector-strong -fPIE -MD -MQ 
> libblockdev.fa.p/block_export_fuse.c.o -MF 
> libblockdev.fa.p/block_export_fuse.c.o.d -o 
> libblockdev.fa.p/block_export_fuse.c.o -c ../block/export/fuse.c
> ../block/export/fuse.c: In function ‘setup_fuse_export’:
> ../block/export/fuse.c:226:59: warning: passing argument 7 of 
> ‘aio_set_fd_handler’ from incompatible pointer type 
> [-Wincompatible-pointer-types]
>   226 |                        read_from_fuse_export, NULL, NULL, exp);
>       |                                                           ^~~
>       |                                                           |
>       |                                                           FuseExport *
> In file included from ../block/export/fuse.c:22:
> /home/rjones/d/qemu/include/block/aio.h:472:36: note: expected ‘void (*)(void 
> *)’ but argument is of type ‘FuseExport *’
>   472 |                         IOHandler *io_poll_ready,
>       |                         ~~~~~~~~~~~^~~~~~~~~~~~~
> ../block/export/fuse.c:224:5: error: too few arguments to function 
> ‘aio_set_fd_handler’
>   224 |     aio_set_fd_handler(exp->common.ctx,
>       |     ^~~~~~~~~~~~~~~~~~
> In file included from ../block/export/fuse.c:22:
> /home/rjones/d/qemu/include/block/aio.h:466:6: note: declared here
>   466 | void aio_set_fd_handler(AioContext *ctx,
>       |      ^~~~~~~~~~~~~~~~~~
> ../block/export/fuse.c: In function ‘fuse_export_shutdown’:
> ../block/export/fuse.c:268:13: error: too few arguments to function 
> ‘aio_set_fd_handler’
>   268 |             aio_set_fd_handler(exp->common.ctx,
>       |             ^~~~~~~~~~~~~~~~~~
> In file included from ../block/export/fuse.c:22:
> /home/rjones/d/qemu/include/block/aio.h:466:6: note: declared here
>   466 | void aio_set_fd_handler(AioContext *ctx,
>       |      ^~~~~~~~~~~~~~~~~~

Yes, thanks!

Stefan

Attachment: signature.asc
Description: PGP signature