[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] docs/efi: Fix wrong compatible in dts example


  • To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Thu, 2 Dec 2021 15:24:40 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pMut5AUiKFNEZm+rPzI75XxpolMLFaHvrDxTGjbU9Ps=; b=UbXHsWqFMMrOCtmDmYGeXetEsHwUMJplInvvJRSIwqS1FOx9muJ2M8KJ8yqQZzzKVwnwuYtjglsMBTUlA1KQFDKg45jzznWiU0kuBBufcDm0xmwfR+NRblEivFHQRUVgOdcTv+G9Kt5WcXqtogsJpPsq31URS/rmTGp0FbCA6O5SAT4jhbNrTK7nysM+eDUoLRNk7R+innNHwh0msnIdSBtUDseZIG0O5T5K1RCMD99gHnKmB+je+qf+wE8TP3Clq0ORO5iH74AnBwVQdvZ74wYd93yum8l61x9/FjPjNp6ZEQCkA43n8C7ineHM/XRWWd4Y2bQbTcinyBHXu+5Utg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j6WGvaaqlmVMQbjVT6eZfztFCbW6RZwIGdmjA/IQ9gXFkeAMRK2AOGyzzPn0av/Sy7y+dIZg5YPiK5hTzJMbLNxV9fLty5NW4D0NfyUNj7VREov+dc3MYgc1zqGWN+zC00gR6XAO8F+Lwf3+IXcHQNCVebqKUo3m9Yz/qKAPWT17JS9myxQLbitphq/vpH7P1u5bn+phARJZR9NkwCixK+fOXsqkx70oitgGeZ5mlX773Mfb76/FK1lrnIq+dYVk478ESxyguMrRuUK4UNtFRtCzm0FA1bhjOW/Lu/xUX0etybBmdNtcST2LhJi6Q+rVDkgMaYQPRrz6pPyzt4C7BQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 02 Dec 2021 15:25:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHX544UfhMBQb0bWUyJNXlX8DEMHawfUlYA
  • Thread-topic: [PATCH] docs/efi: Fix wrong compatible in dts example

Hi Luca,

> On 2 Dec 2021, at 15:05, Luca Fancellu <Luca.Fancellu@xxxxxxx> wrote:
> 
> The example in section "UEFI boot and dom0less on ARM" has
> a wrong compatible for the DTB passthrough, it is "ramdisk"
> instead of "device-tree".
> This patch fixes the example.
> 
> Fixes: a1743fc3a9 ("arm/efi: Use dom0less configuration when using EFI boot")
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>

> ---
> Question: Does it makes sense to backport it to 4.16?

I would vote for that yes.

Regards
Bertrand

> ---
> docs/misc/efi.pandoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/misc/efi.pandoc b/docs/misc/efi.pandoc
> index 4abbb5bb82..abafb34527 100644
> --- a/docs/misc/efi.pandoc
> +++ b/docs/misc/efi.pandoc
> @@ -222,7 +222,7 @@ domU1 {
>               xen,uefi-binary = "initrd-3.0.31-0.4-xen";
>       };
>       module@3 {
> -             compatible = "multiboot,ramdisk", "multiboot,module";
> +             compatible = "multiboot,device-tree", "multiboot,module";
>               xen,uefi-binary = "passthrough.dtb";
>       };
> };
> -- 
> 2.17.1
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.