[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 1/1] Add suport for SMBIOS tables 7,8,9,26,27,28 to improve virtual machine stealth from malware.
- To: Anton Belousov <blsv.anton@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 2 Dec 2021 14:45:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eBqjxjzAKNWmMoaVdx0+u0F+oZJWaI43KvGtrAVKrb8=; b=lLK63aKS1kqN4iZzuhC+2L5GOwRgc0hQ2VhdYkjJYfBUyZv1u5loka3NK121Pyw7WLq915CblngZB+g6CyX+tZtvjBRVZ3UUcvxo4iXS/MDsV312YZ2GhKomqDLC3qCubX033QHBqoFvb8+bsgEc2xuuUZArCz8pWt+YdHpvjPSrnNyqOWguOI6XXWevmgGaMUPSZVi1nZsiC/0DRvieoYyFzYjLcdwv3AR5EyefmX6groQsZj3TmnEKkdeLA+cRhWdEaJEnA46lQbeTE+CZczg9U611JOnKMEUhh4TD6Jss/qVcNq98Phl8neJBNGO44Es21N2CAcYrepYXrdMFyQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ps/BS6POLQkkPrNsO1GZrkP0CYqt481w8GhwW4TbU2V4vKM8Y4ryT32vTziX+stxveTbfgKdprVrnXYUBoLJXTvsa3E/N/y5FBKoUj8KozLynMVwnv7l3v7trEOFZ0qNPs3obbSil7qkpqkUABKf2JyclJyhRC66u8vxHe8yEpCWVfR3VYlxgPf82pHuBa6pbcR4aSCetc1IyNX00WmjzDcNbd0P1NqwynRb7UP2EnWQGm2I2UpLN0Wkoq9pq0eHP/7bBLlu485JDcY8LL2DqZpgJO58zbcZWJ2Sv0rCROjR5FjNoqtIJ+CI9bEzTNGCIq/YAFUgAuBIR9+efc2QKQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 02 Dec 2021 13:45:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.11.2021 13:59, Anton Belousov wrote:
> ---
> tools/firmware/hvmloader/smbios.c | 146 ++++++++++++++++++++++++
> tools/firmware/hvmloader/smbios_types.h | 76 ++++++++++++
> 2 files changed, 222 insertions(+)
In addition to what Roger said: Without a commit message it's also unclear
whether it was considered that the extra information might misguide a guest
(kernel).
Also, even if I expect you simply cloned existing functions: Please try to
avoid cloning style violations; see ./CODING_STYLE. The most noticable to
me issue was missing blanks around &&.
Jan
|
