[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/8] x86/boot: Drop xen_virt_end


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 2 Dec 2021 12:56:11 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fip1oEKgQDVzbRYQv8yGd4jqLPdCUUi+hGnXJ1ew0gI=; b=WjrNru5aaf55dbIzGLkgdx3vK7/xuokVpzX97ray3JjVSy+TG3DsGLciKMqGy44OHQQImHOo9/zhLzJeFhN1LAjUGUOXSH5jl+VD6tlztP0VzIL9hauTAI33tr+Q8sQ8lGGoxYMcp3Z8dTSqX5x0yRcxXNqw5ls7uWVR1sNjqkNvEtD3psMGCr24IP8lWH1lyJ+Latpkh/v3ZTN7xtAN0wcqE0iDhK7QuIJubqT3Wkw2OdRIUaeOCXeHaIKR2qcG3c2oHjNezFyOaALkI2Xhacz6zPgPf2vkdUSWJZCUkIN9ch1aX5aqNGMc39DgRGIhjPegEp5tTMLIjRM4SIvtsw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H8vYNntMpxc5fYnzoZG6J7Yc+NVeKPnoxYNg0+xyqtq2lsYOFsVP+tQSQjZul80jDLSMPBU6U56Gx8qb1uWghMJyqBBqC0xggDDvGsWI8DeE0IpgPN7ATacFsD9Otx9QWQVsfZs/+ZE/QRRv36x4iVydEBMVAfMgQQsFmUn1MqZPXH4d67soc16TyxyifGRnW6Gf0VhNs3laS3uSsColR2pNNXDkwy070aIQvqc8fnW/wkRuXQ96ZXXfbrSkzAQH2f6s6DdHDQS2SRid146ZdByLThRzTZ1zLhbI1xEahQTN0fv2fqwEThP+VjchxbAMlNP/qaq0YbqUcx1csX8T8A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 02 Dec 2021 11:56:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 30.11.2021 11:04, Andrew Cooper wrote:
> The calculation in __start_xen() for xen_virt_end is an opencoding of
> ROUNDUP(_end, 2M).  This is __2M_rwdata_end as provided by the linker script.
> 
> This corrects the bound calculations in arch_livepatch_init() and
> update_xen_mappings() to not enforce 2M alignment when Xen is not compiled
> with CONFIG_XEN_ALIGN_2M
> 
> Furthermore, since 52975142d154 ("x86/boot: Create the l2_xenmap[] mappings
> dynamically"), there have not been extraneous mappings to delete, meaning that
> the call to destroy_xen_mappings() has been a no-op.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

While there's a contextual conflict with patch 4, my understanding is
that this one is independent of that. On that basis
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.