[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] IOMMU/x86: switch to alternatives-call patching in further instances
- To: Andrew Cooper <amc96@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 2 Dec 2021 08:24:15 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fzxGWKaoW59Od2WpYxt5a7eai2jl7ItmwhCtKOxvhiI=; b=oVTmhfszWVafRY6zKJBoV/pNButWmk4VYIZkvRa3/kGGWlbwvH17o9T+8KOKH+UBc7cCVl8T2XnlY1yyT4LnFLt0t/tU7qYj5HEu1zbgewQisv6SxX97TYlQ3T2EKAyY2S+RJ1kaTSVnhSuvoJKOskLIywdEBHQHnVkHmh3/gLV3PSGsYe1veid8Fy2s2X22Jl0+hCGER6s/hKxlm4LtySRQun2SPtQtnOvVGVFuVdXcjRGIZ6u13e7Z4taORaEygC6/hXfACOuMcbpLNk/OTnAP3hbUAZ1ENrGQcGANJzC4caa8T2RNrJhSd0mmGkqTNjDLz+r72qndsRrr05OKXQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RCc9VQbwNLgYa1LnyZ0X62lqda6fM714DOuLTYCzPGgbs34nBt5RYA0KJ7sgaJc3VklG7laE8kuDJ0WT6xwaXQa5zmHXQ7W62WK4PuFgRd2JjHgidLl/lgOpoLh3ypVFOGmrpNZhKnZOa1Op3/4UQmFmsIV3TPfeTVesn4TNWzM1iAtmUTchCgjcSSYN7bbU4ivz15+OL0cqr1/Lg1t0gEEzhrEcNi8B/0tb0F8QtR2Sv2fmsD5YJoVIrJANCzdvTNbJLItZz0D1MxLro1ORg0USs61zHp8SIa+cBTBza6vUWdF8HMRQUZCYo/CesBDIAF5g4NUZAd6IZCbK5qs6cA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 02 Dec 2021 07:24:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.12.2021 16:13, Andrew Cooper wrote:
> On 01/12/2021 09:39, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/passthrough/pci.c
>> @@ -1457,24 +1462,24 @@ static int iommu_get_device_group(
>> if ( !is_iommu_enabled(d) || !ops->get_device_group_id )
>> return 0;
>>
>> - group_id = ops->get_device_group_id(seg, bus, devfn);
>> + group_id = iommu_call(ops, get_device_group_id, seg, bus, devfn);
>
> So I was going to suggest adjusting this to use more pci_sbdf_t, but the
> Intel implementation can fail and return -1.
How are the two aspects related? Wouldn't you mean the parameter of the
function to become pci_sbdf_t? If so, I'd view this as an orthogonal
change. I'll reply to the question of removal on the subthread of patch 4.
Jan
|
