[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/4] x86/PoD: HVM guests can't pin their pages


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 1 Dec 2021 11:53:36 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0OKNfDnsUjtw+PEZVjp549hJsBhAjbhkyxNkaubCrTw=; b=e/IEfBMBeEA03WImd7WmMt1dpA9nJkbjXdZRjLJR6RqqyO8iPSt3esURIz0W1Y0ErP6ApGd2vd6J9COc8ytYM0GNOjT2Sh3Odeh86fg1Ew+1ZdMgX98N3zO81JNRoNDSefPlEif8si6xL/EdN2sXw4kN3HiYusKQvDTTzKYW2GjggyT2zq/X+5cMQ9/v7o6sHJogzKWPreqY6Bj/oMRE6uvH+YvxA7lEYfOU/X380SJeey3FfqL8jmMNyxiHaDtq9f962sggCdQoXfdHWA4DGr7veeoYRBtwfOeccVC2/b59dkLOnsIynlduSVJ5uUPNDYqxVFd/EgTx5gzy8iFeRw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJBBbvD0w7X4v3pY/jwz8YMyceXAaw8Vq5k63hcV2BNRxC6V5BFPlLX/cg6NtTX0bFHphr/2Vs0lbTxaUdmYCeP9Hf5HE3s42Jt8V6HpKWz645lM9mDGDC8VBJIF+o4wFUpGZ0vrQfIhpyfz+J7bJ235IgWP7Su7i9mqDMg44e35PdoPZogX/uxHPmq76Aeblx0IX+ixIZb29vxU43RMNB5rIOPbkzBHMKLiqcBzc0N7r4oIpxobVR2l56tpNE6obEIbNouP6rRwmHVVCNgr19hQN8/XiHbCJt3IIupRgGHmNicvQj93aImxQ4mP2fO8V/Z5Um07GvcgkRDZerCHrg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Wed, 01 Dec 2021 10:53:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Pinning is a PV concept, used there only for page table pages.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
I'm actually inclined to hide _PGT_pinned in !HVM builds; the downside
of doing so is some new #ifdef-ary which would need adding.

--- a/xen/arch/x86/mm/p2m-pod.c
+++ b/xen/arch/x86/mm/p2m-pod.c
@@ -260,9 +260,6 @@ p2m_pod_set_cache_target(struct p2m_doma
                 goto out;
             }
 
-            if ( test_and_clear_bit(_PGT_pinned, &(page+i)->u.inuse.type_info) 
)
-                put_page_and_type(page + i);
-
             put_page_alloc_ref(page + i);
             put_page(page + i);
 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.