[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] bitops: Fix incorrect value in comment


  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 1 Dec 2021 10:38:31 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PRjudJYaDJBTDEpmDQGWloSQtoD3kcm4WrMbo4YMq/4=; b=ZaeMJcl/AiMgaqvZc/MJSaWxK17szQOn/tY9vwTw1uKYWowa5oe3pF1ZdpAzLJUiQhJPXKZJa7LuOqaLvB14cKb+oGBvGCPOMlWOk6swE4dtENy84igCTxZ0hDSg7zEwqjxv/JIZaUb/3qmhDKbZvN2yei+GhP0L1dWPju006yWY2WG1bxbwXA3gSlPzgDt0comGc8diT9hZ/XcxxPd3VsaShMSU4aIFF8WjWjgrvo/zj1ZLyzS2nhcdwsNIwQCnRKlkdgsSqKXVmNovU3aV805e2SRFFe56z+RTRr/B1C9EbKXR5GqWEuEB2brx4ahDvSWqfEDHLFYrT8WQgdS7rg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mpQXvQo9hGLQi4ufHTvYiOO6iHVN+sRKvoMcReaSNEKMdK4hDFHvACKD/fNveiCwW8eUbVsBnx9T6d5PA7CpQhhE60YMdirnfGHbSob8PSTOpICo8zE95MEoB+KjNTsweOIHyucCzc5xCk15vIR4Eje4+zKZuitiGwnFHwas9O/WhyL8Q/PchHqEHXwPqGIN7ciBWpbSaHyc7mRIRRWBesLmjNsasXgWbLN4lVestFdl57G9M5WqFKtP3BGMXxwQ9U9B8jAC+P2NkCOlAl4ApQm+zV+N+D9ReHDcE+5FK+adr8O+pQ7kxZLidB9D52S/Dgxcixs4leWvrECKvP5P8A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: sstabellini@xxxxxxxxxx, stefanos@xxxxxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, Ayan Kumar Halder <ayankuma@xxxxxxxxxx>, andre.przywara@xxxxxxx, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 01 Dec 2021 09:39:46 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 01.12.2021 10:33, Julien Grall wrote:
> On 30/11/2021 18:12, Ayan Kumar Halder wrote:
>> --- a/xen/include/xen/bitops.h
>> +++ b/xen/include/xen/bitops.h
>> @@ -5,7 +5,7 @@
>>   /*
>>    * Create a contiguous bitmask starting at bit position @l and ending at
>>    * position @h. For example
>> - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
>> + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000.
> 
> ... there are two extra changes here:
>    1) The bitmask is now described with 8-characters (rather than 9)
>    2) 'vector' is replaced with 'value'
> 
> The former makes sense to me, but it is not clear to me why the latter 
> should be changed.

Would you mind explaining to me in which way you see "vector" accurately
describe the entity talked about?

I also think the commit message is quite fine as is.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.