[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fixed an incorrect value
- To: Jan Beulich <jbeulich@xxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>
- From: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxxxxx>
- Date: Tue, 30 Nov 2021 18:14:07 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=suse.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=amtjdVD53kEO5nY/whsZSNi81SJy2uo2q4XMGCnMdn4=; b=g54e673rEm65vFi5l8TW+Za+T0C6UHTklPDBFJYZb5RHcp5eEZoKlM1f/i+JxNTY3ASyp2NP9Pa19STChEqgXF6SkbcOwctc/QHd554mUiCGnFtKq7ZN6Op3l/z7pbODCKStl3qSvXNbm/ij4qfarmSw+Ccrk9fprW3RQezsdt9bleqBhm0f5Ja3Uq4UBTL/ZX4+0tTiLKQU0xgqvJR4VbXT/61usLO+D6NH71dJ9yZkcknlFt6DuRqxU4S0WjhYWhwBw4wB8Y4gqcxVc8pv6oUG6nSXBpAa0TkFsWd/VkIK5uu3UUlZAynOJwjZjZ2rXLizgL+dyYzR1BTtKjq8OQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ldDjg8LlIsuEHrXZ+IYasF7tg4KHVusyGcSKOTD1tdNZCKpe2J4MQbIMKmcg/BbNdr552PlMVD0MZf3AdA4KN8myt7nvcyibr+MLR2vjCzcnmwRQ+oUqO8Z0Ffx+D135lluT7QMJkwvVu6aFLcnYdlyQ6yB6KrXCmWxRbDAGvi7X8dmIkudXFotnQP79ELKDSxpY0Bw1LxM+Fmg8u2/1V8pioZRpwNsfLQgn/ZfuPWPxqWKDHRB5LLjUZVXsj04J2GKtWuoxY41D4Fg3tW2smYw6GBPkRxSDu0waJtyypJYCW2qBDBcbpGdkrcK6OeYDfmK9Ucms6smabhcV3HUO+Q==
- Cc: <sstabellini@xxxxxxxxxx>, <stefanos@xxxxxxxxxx>, <julien@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 Nov 2021 18:14:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
On 30/11/2021 10:31, Jan Beulich wrote:
On 30.11.2021 10:37, Ayan Kumar Halder wrote:
On 30/11/2021 07:18, Jan Beulich wrote:
On 29.11.2021 20:44, Ayan Kumar Halder wrote:
GENMASK(30, 21) should be 0x07fe00000
Please can this have a meaningful title? E.g. "bitops: fix incorrect
value in comment"?
--- a/xen/include/xen/bitops.h
+++ b/xen/include/xen/bitops.h
@@ -5,7 +5,7 @@
/*
* Create a contiguous bitmask starting at bit position @l and ending at
* position @h. For example
- * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000.
+ * GENMASK(30, 21) gives us the 32bit vector 0x07fe00000.
Once at it I think you also want to
- replace the word "vector",
Should I replace "vector" with "value" ?
Perhaps, yes.
Thanks for the review. I have sent a v2 patch.
- Ayan
Jan
|
