[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/18] IOMMU: add order parameter to ->{,un}map_page() hooks
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 30 Nov 2021 15:45:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=49nr4D5Hpcc/0TUTSQTh2TMpELDhNnxW7fBkW8w4MFE=; b=UBOTs49Uf3jBVrNZbHyAMfLFeCJUnKuAbWitjuIdGHF0LAdEOGDX7ku3+lzSjd+rrGTXHqV7F9jtrL2Dvfz768iSGhNV4X+PiO9YuXhUT1Tra2M3H7Bg7/HhNn6Xw5xjkCjPks/pVcWecy6Dp9XiTEBukh3LYkhQWy90AWZ3olm5Z8/trxCI16ZfV6CMx//6+XifmHugzy4x3KHt2ZL9whM9Jv3p5b3aYgtWkzwUFnaRU4S5G/lj3H9J+v/cJdFUT+Ij44CwURHfDDb6ADWsFWpRzsjrQS++pmpBSp/HG7plMlxZiaycdRaciYGhyM2kTDEv75PuSDMVQsuzQhgy8A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rhc7CfnfSaRv+cKKyYnwe2iSfBziXT2GkdVOoioh64W2BXJeZ1GqKSw8KIz+IWsDieNk/+iXlzEF+cPChzfSRqN+J5Rp/FVhAQ5Z2QvtYbSl74XZUlbZk53q51rHptvBjojpRdNPsAW3FR0KY3nAeQNlpN+vnuPR8Yt3fkBmsR2g878jQ+NIiPsNsM4Wrb4nWzSx4Y6sgQ18Rtka9ShBWffWBHr2mVs0BsiX4sDl5WjPmweARi1pLLfv0m+a/qdaDWnCVXXsdDzjPHSEfL8OMf2M2e5VbvZ4FNo8dYBslXIZw+9eh8ikPOKN9Jsx/uaSXcPnklTB13fjz6vWwAj06Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Tue, 30 Nov 2021 14:46:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 30.11.2021 14:49, Roger Pau Monné wrote:
> On Fri, Sep 24, 2021 at 11:44:50AM +0200, Jan Beulich wrote:
>> Or really, in the case of ->map_page(), accommodate it in the existing
>> "flags" parameter. All call sites will pass 0 for now.
>
> It feels slightly weird from an interface PoV that the map handler
> takes the order from the flags parameter, while the unmap one has a
> function parameter for it.
Well, I wouldn't want to call the unmap parameter "flags" just for
consistency. If there ever is a flag to be passed, I guess that's
going to be the natural course of action.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks.
Jan
|
