Re: [patch 09/22] MIPS: Octeon: Use arch_setup_msi_irq()

[Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>]

On Sat, Nov 27, 2021 at 02:18:48AM +0100, Thomas Gleixner wrote:
> The core code provides the same loop code except for the MSI-X reject. Move
> that to arch_setup_msi_irq() and remove the duplicated code.
> 
> No functional change.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxxx
> ---
>  arch/mips/pci/msi-octeon.c |   32 +++-----------------------------
>  1 file changed, 3 insertions(+), 29 deletions(-)
> 
> --- a/arch/mips/pci/msi-octeon.c
> +++ b/arch/mips/pci/msi-octeon.c
> @@ -68,6 +68,9 @@ int arch_setup_msi_irq(struct pci_dev *d
>       u64 search_mask;
>       int index;
>  
> +     if (desc->pci.msi_attrib.is_msix)
> +             return -EINVAL;
> +
>       /*
>        * Read the MSI config to figure out how many IRQs this device
>        * wants.  Most devices only want 1, which will give
> @@ -182,35 +185,6 @@ int arch_setup_msi_irq(struct pci_dev *d
>       return 0;
>  }
>  
> -int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> -{
> -     struct msi_desc *entry;
> -     int ret;
> -
> -     /*
> -      * MSI-X is not supported.
> -      */
> -     if (type == PCI_CAP_ID_MSIX)
> -             return -EINVAL;
> -
> -     /*
> -      * If an architecture wants to support multiple MSI, it needs to
> -      * override arch_setup_msi_irqs()
> -      */
> -     if (type == PCI_CAP_ID_MSI && nvec > 1)
> -             return 1;
> -
> -     for_each_pci_msi_entry(entry, dev) {
> -             ret = arch_setup_msi_irq(dev, entry);
> -             if (ret < 0)
> -                     return ret;
> -             if (ret > 0)
> -                     return -ENOSPC;
> -     }
> -
> -     return 0;
> -}
> -
>  /**
>   * Called when a device no longer needs its MSI interrupts. All
>   * MSI interrupts for the device are freed.

Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]