[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 10/11] vpci: add initial support for virtual PCI bus topology
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 24 Nov 2021 13:36:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XxsJR3dQtPz5jbsnTdvLVtmMwCnkxV+5wzoIKt4r9WM=; b=ILkB34KSGRTtq1YajFQTwaZ9XflpKspDIT2An05qaOhBkjn8Ag0I1Yii8hhsKoM889QLsdnfJ+FqE1peLcZUyfeaerUVe0RNd8k1cNPjxralzLCZvaHJl+vOSqPucTkybBK5u6SAMxEGaBqxs8Sy4loMEAYf19VvARZhrUJH79K/fa4RLgqH0TdHcMtQpzUFLpk1jzG3kLEQbl+y74JuldhzauPewS5EKZNtazEyRwDJTOPeXr+3AdPqUTz4PFqkOWdEcwXh5GcS9pPkGckIEAzZJnICJe745DCqqLjxoYDNk9YoMGnc+Z6lDC0oQV+jiM8h9k3AlJ/13KBDGwQ2Sg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQkSYG+ZJAMEPEFKCH8+6ZO4cdbH6HwWhCj0nFE6WMVGswTrqS9ptKcmGjC+2pGXy64k/r/jt3eZ685oiu/TJGj0aTBjnI0h4cymc9BbgYDYbZdJAvlUpckKPEZO5uOj35CNRQerYbqI5XzP47IiLOVHLLOcXY7sZDyq9irJL3r9gkgDkOG4Elb2vIImBd/WyTuFRBkh9h3A02TQqNci1YkqjxH+CzQL5bUbxDzt1lbJZjMVJ3qo2zmReQPviQpKcpFd+uoJRuL+D9O1mHbyGzCBAWsm3lRKHJr1eki4d0jGUyQJe7tN4MTUm/FoxPZ24s5TzMzB7jZ+8X/Uuz9wAQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 24 Nov 2021 12:36:48 +0000
- Ironport-data: A9a23:Z2MqqqChNc+ITxVW/wTlw5YqxClBgxIJ4kV8jS/XYbTApDsn0zAAz DFJXT+OO66OYmGmf95wOYixpktUu5+Dy4A3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMo/u1Si6FatANl1ElvU2zbue6WLGs1hxZH1c+EX540047wYbVv6Yz6TSHK1LV0 T/Ni5W31G+Ng1aY5UpNtspvADs21BjDkGtwUm4WPJinj3eH/5UhN7oNJLnZEpfNatI88thW5 Qr05OrREmvxp3/BAz4++1rxWhVirrX6ZWBihpfKMkQLb9crSiEai84G2PQghUh/iAeHmo1ti /Z0qI2oEyERebTyuM4tekwNe81+FfUuFL7vJHG+tYqYzlHccmuqyPJrZK00FdRGoKAtWzgIr KFGbmBWBvyAr7veLLaTUO5ji95lNMD2FIgepmth3XfSCvNOrZXrHf2XuYICg2ZYasZmGKb6Z 9E2UydVYDffWTcUKkkpT41jg7L97pX4W2IB8w/EzUYt2EDLxRF1+KjgNpzSYNPibexPgkudk UfX8G34Dw8yOcSWzHyO9XfEruXChz/hUYQeUrix7Od3gUa7z3YWThYRUDOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYGUtpNF6sh6QeCyoLd+QPfDW8BJhZ/b9ghuN4zVCYd/ FaDlNP0BhRiqLSQD3ma89+8rzm/JCwUJm8qfjIfQE0O5NyLiKY3gxHUR9BvCpmciNHvBCrwy DCHqis5r7gLhMtN3KK+lXjFnjatq57hXgMzoALNUQqNyQd0Z5WsYYCy3mTK9vZLLIufTV6ps WANno6V6+VmJYqWiCWHTeEJHbeoz/WIKjvRhRhoBZZJyti20yf9J8YKumg4fRo3dJZfEdP0X KPNkQBj6poOIDiJVLJme9iXM4Mz84jKJf2wA5g4ceFySpR2cQaG+gRnakiRw33hnSAQrE0vB XuIWZ3yVChHUMyL2BLzHr5AiuFzmkjS0EuKHcijpylLx4Zyc5J8pV0tFFKVJt4046qfyOk+2 4YObpDao/mzvQCXX8U2zWLxBQxbRZTYLcqvwyCySgJlClA6cI3GI6WMqY7Ng6Q/w8xoeh7gp xlRoHNwxlvlnmHgIg6XcH1lY76Hdc8h9i1lbHZ9ZAv5hydLjWOTAEE3LcdfkV4PrrIL8BKJZ 6NdJ5Xo7gpnFFwrBAjxnbGi9dc/JXxHdCqFPja/YShXQnKTb1ehxzMQRSO2rHNmJnPu7aMW+ uT8viuGEctrb1kzV67+NaPwp25dSFBAwYqeqWOTeYINEKgtmaA3QxHMYggff5tRdE6dn2TCj G57w34w/IHwnmP8y/GQ7YispIa1CepuWE1cGmjQ97GtMifGuGGkxOd9vCygJ1gxjUv4p/evY /t71fb5PKFVlVpGqdMkQb1q0bg/953koLoDllZoG3DCblKKDLJ8IybZgZkT5/MVnrIJ6xGrX k+v+8VBPenbMs3SD1NMdhEuaf6O1K9Il2CKv+g1Okjz+AR+4KGDDRdJJxCJhSEEdOl1PYopz P0PoskT7wDj2BMmPszf1nJf9niWL2xGWKIi78lIDIjugwst61dDfZ2DVXOmvMDRM41BaxB4L CWViazOg6Vn6nDDK3djR2LQ2ed9hIgVvEwYxlE1OFnUyMHOgeU63UMN/G1vHBhV1BhOz8l6J nNvax9uPayL8jpl2JpDUmSrF10TDRGV4BWsmV4AlWmfREi0TG3damY6PL/Vrkwe9mtdeBld/ a2Zlzm5AWq7Ipmp03tgQ1NhptziUcd1p1/Ll82QFsiYG4U3PGj+iai0aGtU8xbqDKvdXqEcS TWGKAqoVZDGCA==
- Ironport-hdrordr: A9a23:ZTT2i6Csuc3EMO3lHemo55DYdb4zR+YMi2TDsHoBLiC9E/bo8/ xG+c5x6faaslossR0b9uxoW5PhfZq/z/BICOAqVN/JMTUO01HIEKhSqafk3j38C2nf24dmpM JdmnFFeb7N5I5B/KTH3DU=
- Ironport-sdr: 2NgqUyNLJo+XZEfDXcfyeJXhMCGW33RaDaIdhQ87lCnTuBoOO6rN8AVoxpofZjXsSAbhMu9KlG M4vMu9PjVZrA+kYYL8kjhzpFQd3Pim4IeDy3tqpH9D87y4IICSkdvq3HCPdOm5zL9iMRYJxBxV IMsNXKpMbpHEa4NWshtCW+sXUx2mDD6cX3T2Ld+trcFnragjfuYWoepLYE34YOeWjkaXfV3JlS sL4K3pTSpAwGVZEV3NK8RtBrVCIF1Ssh6Gmhr35Oamk7Z88L0z1S+X2a58LoYrBgDJWr63VH2a dXWhk08IbTN28lZwoS079jIc
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Nov 24, 2021 at 11:28:18AM +0000, Oleksandr Andrushchenko wrote:
> Hi, Jan!
>
> On 18.11.21 18:45, Jan Beulich wrote:
> > On 05.11.2021 07:56, Oleksandr Andrushchenko wrote:
> >> --- a/xen/include/xen/vpci.h
> >> +++ b/xen/include/xen/vpci.h
> >> @@ -145,6 +145,10 @@ struct vpci {
> >> struct vpci_arch_msix_entry arch;
> >> } entries[];
> >> } *msix;
> >> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT
> >> + /* Virtual SBDF of the device. */
> >> + pci_sbdf_t guest_sbdf;
> > Would vsbdf perhaps be better in line with things like vpci or vcpu
> > (as well as with the comment here)?
> This is the same as guest_addr...
> @Roger what is your preference here?
I'm fine with using guest_ here, but the comment should be slightly
adjusted to s/Virtual/Guest/ IMO. It's already inline with other
guest_ fields added in the series anyway.
Just to confirm, such guest_sbdf is strictly to be used by
unprivileged domains, dom0 will never get such a virtual PCI bus?
Thanks, Roger.
|
