[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] rangeset: add RANGESETF_no_print flag


  • To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 23 Nov 2021 08:38:56 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HHnV7MU7uIYAtUCZ4oASC2bkm3izyOi9lC5heFtHsEA=; b=c2grFKi7e3GZPNaGt78Na+weQwZzuJhmm9YD85oRrrzdvxbpBHUZWA2DPi5WGKfG6O7LUV6OjpRtDJtaHe+6jlZ1drqLWOuN+9WzLiqtuWY5uuTvOiw29Qj4E2gQQdpG+no8yEsO3t4XfGUsgJzSur66mINHuhy/G1qByYWt5Bdes9MwPTKLf/N7/IzODdjWRl0JuD5i2ECKAWiQGtEEBJH5AgD9n7qF0FV9MSM7MacT8sfGS9ANYu/Fs0X3a/hK51zkK4pvn+udnACEs7oQhTa/40uH/JnR99FWyG5Z4JaWZ0Vq2VC8iBnlZ0Hmtgk92HYxiiThgtxfyICDrRWogw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTiXVKnRgBYetc3WFQkI5PhJM6tSksZRMXYJ96eyayvL3Yg8Vfdo65F1OTQGNBoovwqcydFFqQ79Jig+//P4Ro5wclDoV5MaeESoorMD5xjC14EpU/5YLY2l3q7iLMPN3aI6UNCqH1HW/+gXz1/8Vaza1/bi8ZsEPzlQ0b5WdQTVw7MWV9L9NxhOICrrsLWF7kBvn3B1DEDtHJ9OGsd6h1221dcHDw+/LWxaqi4bYldJgpwng1mZFuVOrJC+hf4dTVXZLY2TvEjLoqnbpjCN5EORBrbk45IkSlaNTynpBQBBTv0XuOdXcQVrGJlRXxgq/+gKjrCgXQiKPK3jR9JERw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: roger.pau@xxxxxxxxxx, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 23 Nov 2021 07:39:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.11.2021 10:28, Oleksandr Andrushchenko wrote:
> --- a/xen/include/xen/rangeset.h
> +++ b/xen/include/xen/rangeset.h
> @@ -51,6 +51,9 @@ void rangeset_limit(
>   /* Pretty-print range limits in hexadecimal. */
>  #define _RANGESETF_prettyprint_hex 0
>  #define RANGESETF_prettyprint_hex  (1U << _RANGESETF_prettyprint_hex)
> +/* Do not print entries marked with this flag. */
> +#define _RANGESETF_no_print 1

There's no need for this, so I'd like to ask that you add ...

> +#define RANGESETF_no_print  (1U << _RANGESETF_no_print)

... just this. In due course we should do away with
_RANGESETF_prettyprint_hex as well (unless you want to do so right
at this occasion).

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.