[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen: detect uninitialized xenbus in xenbus_init


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • Date: Thu, 18 Nov 2021 17:24:46 -0500
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Md0tz9tREW9RabkkUpcmeh+S6AjifQUqo23EL6a5vBI=; b=Jq+yMCX2t3hwRQuzFq/Pc8jdGKLk0WrWSJKVYiwM4WxFY6c5z1dPrcN88288vs7B2RLopKMbndfj756XgVCqQNWEoZragVRFksUpUiPECfeOlSFn3jd7hSWBRNonfQ+cVt4wBPMiAzrlRjiSY7asdGSULiOHNbkRDNMOI6siNmndO0wbm4OvTMMEDqzU7BLv4lO5kKj3rAckJcVNTK0oUGhj/eTty3+fDdW4cVef3DlwlfbRE+HGB5E1ffSSgTa2KcwTMhy//koLJC8zpIVsvkrfbcJtjXYQKIUE+msUujpkTw3XU2rnV1tAWfq1TZ0kQZoyXmmyx2gpigtb+75SMg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XIczXN/aFF66ZSdG3ZnmNPWIiBcb+d5pa91TcClzvEZ4p89ELeK6gc44guzU2UX1OUzPZJRhkuikAM+CXkBHQQ2J9JgdlwGD0whu7vnnfBP+wTzjoDuUID8OHoBkBiuk+EF5r+InytIsUY9Y87ni7M7FyzC3nX8kf0jOCpZW1kPJ0Dvj9cQoYnvVTnILaxFQhExEXc3vxeQxC1qgTOc27K21vDZlGQJJCvJKq9N9v4T0NIN/1J+txm3IJ8zgpYQQtOxAfatEtQnNiseKgIw8LPzLMb6OWJzOSsthSvXzY63zcu3ZjbkfZ/iUliG1/XTxP7MzBmie1GM4jEGucAFwSw==
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
  • Delivery-date: Thu, 18 Nov 2021 22:25:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 11/18/21 4:00 PM, Stefano Stabellini wrote:

         /*
          * Avoid truncation on 32-bit.
          * TODO: handle addresses >= 4G
          */
         if ( v >= ~0UL ) {
             err = -EINVAL;
             goto out_error;
         }


Since this is only relevant to 32-bit kernels then "#if BITS_PER_LONG == 32".


-boris




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.