[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen: don't continue xenstore initialization in case of errors
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, jgross@xxxxxxxx
- From: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Date: Wed, 17 Nov 2021 11:05:57 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z5+aHhp9bWM8ZoMn9iz6HfR3omgHA682Wq8x96d95nw=; b=N46k9gvewViNcFt6+jcR7TXsE7+9yWlOPJ1AsHT/NI2b7saRx14SdQ6lncTXDnPBKIY3nH9/6Q74VY+gj+XfBGh6+WTNxJ2H3m/bKWmQhTz2BoTlXkUQTuKH4jMHaseI2x8sKU6Sdu9S/EKks+Oe4yCotySgTjs+qfE/6X7pmE2t0Jn/PoWzrVQ4H3QzbqC946qNpKRUkEdxWsMZG8cRCrEdpJJVyROO9D6fErqjLdwxego+WZL1kMgio/rmZ3B0pcZsQqmk9bXZjdMh3T1WdpDlR7xM5/d3vLgtHhl0bF0aEm5Fg/voohORVd0dOTS2rmCAq8mHV+MtZov5jjrreA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=obCVJi39PvVwHkcIZqAp79hhmzPyBz1sZVrEdnPDYhuS3NEaLmf0R7NM+rYonBe5ebEpq5jx4grnQQbqXg39yw3gbnfOfS2DWMwDoxJt6NjKkMVQ+RO2Cq9ajfNUtJxVdEUAMRXnVmeECmEmwMm9/bNpdUqFeBjTGbjYhdlb/RVboRmP5HPwKAYUZ9JUYF/Hx1BbbB6OrzopTckqMO2+Sgc7F6Sg1cyTXG42B+ppRabnBB/7qX50kTazx6FUOC6eTkGEY6hgQXtZ1M9QhxazQn5VQwDINVZE0qEi0yfTtOQN661l/0P/QdkuLR6IaI1fcf20bO7+MElsv76w0a875A==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Stable@xxxxxxxxxxxxxxx, jbeulich@xxxxxxxx
- Delivery-date: Wed, 17 Nov 2021 16:06:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/15/21 5:27 PM, Stefano Stabellini wrote:
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
In case of errors in xenbus_init (e.g. missing xen_store_gfn parameter),
we goto out_error but we forget to reset xen_store_domain_type to
XS_UNKNOWN. As a consequence xenbus_probe_initcall and other initcalls
will still try to initialize xenstore resulting into a crash at boot.
[ 2.479830] Call trace:
[ 2.482314] xb_init_comms+0x18/0x150
[ 2.486354] xs_init+0x34/0x138
[ 2.489786] xenbus_probe+0x4c/0x70
[ 2.498432] xenbus_probe_initcall+0x2c/0x7c
[ 2.503944] do_one_initcall+0x54/0x1b8
[ 2.507358] kernel_init_freeable+0x1ac/0x210
[ 2.511617] kernel_init+0x28/0x130
[ 2.516112] ret_from_fork+0x10/0x20
Cc: <Stable@xxxxxxxxxxxxxxx>
Cc: jbeulich@xxxxxxxx
Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
Applied to for-linus-5.16c
-boris
|
