[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/privcmd: make option visible in Kconfig


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 16 Nov 2021 15:55:46 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6ByBp5MZeD59CjWf5VwLe51Y0tIsapc3swcZVUvIiHI=; b=d4Sk0/c7YbpJyFtDYSTSGQYPosrHHZmTysl/Gau4OFge4dN+wiVx9fPWc6Ow+UF3cOmqcsQhQIO7pgIoq40tCuszL8Q4Yb6mRJfUY3aEel5FfdVO6nIZFolxx6uh5oU/li/LwIWq/JTKzQK5f0pDcp34wn1mmVjZwBeXJr9bk7N7qimDayq/DPRwV1mEgwmDABef9FwZi05IGvy5jjtIVrdGYxz6+lHC9EJddBO9n7h0On7Sw93Sh1Xry/pWcwcPb7Lq4Ay0nJ6xY5t7eXSsKu7L4HvCfArNSfpG8RBjKW9IkKMQIojybJpmRA+sA9GQkobVwcoyi+S3JSGH8eScxQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jmLwTlh/3XMT4zYDZhBOu4vPZ/bQ7l87ZllQhF/HAME47bBr+DxEc6cGFsX5QBgYOv8FISQeEXz16OTpJYhX8RrxWOk9fd1Z8qLRZ+C2/SIsV91Nv0yYuOkfFRbv+4/HmwMcqBHyQ3a5/LxPapvNAO/kjbly14w30InNYahiZ4lC1TuakhQB+8V4OS+PlVNCLUq66k43eDEm5NjJTpY1qN5wwbBU2U7SEpgYh5ugaWgqR1GxTdlMPUK8rEjdIx8ZxA9mWk8TyodHpqG45iWjfK+5yWPHlG7+XkOY522PCPIKXOtsf070bzFlxu4mCUsnFUbfy4L/AdA0eU7KLWDWZA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: linux@xxxxxxxxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
  • Delivery-date: Tue, 16 Nov 2021 14:56:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.11.2021 15:33, Juergen Gross wrote:
> This configuration option provides a misc device as an API to userspace.
> Make this API usable without having to select the module as a transitive
> dependency.
> 
> This also fixes an issue where localyesconfig would select
> CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to
> building as module.
> 
> Based-on-patch-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
>         if guests need generic access to SCSI devices.
>  
>  config XEN_PRIVCMD
> -     tristate
> +     tristate "Xen hypercall passthrough driver"
>       depends on XEN
>       default m
> +     help
> +       The hypercall passthrough driver allows user land programs to perform

Maybe worth adding "privileged" here? Albeit of course that's different
from the use of the word ...

> +       Xen hypercalls. This driver is normally required for systems running
> +       as Dom0 to perform privileged operations, but in some disaggregated

... here, so there'd be a small risk of confusion.

Jan

> +       Xen setups this driver might be needed for other domains, too.
>  
>  config XEN_ACPI_PROCESSOR
>       tristate "Xen ACPI processor"
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.