[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/10] direct-map memory map
- To: Julien Grall <julien@xxxxxxx>, Penny Zheng <penny.zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 16 Nov 2021 12:30:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HAF4dnWUTlGBODvANNc/XeWb7Q5R3sebTFH/Ja2y1R4=; b=i1hRL/a9Ryb6+4IlpVAmWqf735OiqK8/F9OUCz0f8hpol2kGsowkkDPlsKfICxunSuJvcC1GMBJdCkfNG2apbrrue18//ciOvFhZM3G9Nc0A1hP9+nmAnDF2bSrGraCKc/KXyBYthkUD1bYH2znUHLkzQU2U5mMBgenkY2ezoR3QWFNFFgwZGDt0PUS+BM4lV0TkJmYR0pgRqVvXSI4z4us6qudXEd/ef58J/a0EYjM2jm38/MxWzdvcJprnZrGzX8M8VLYKu6xzFSc/ZRPF1Yjky/dNYWFAVW2cC5x0eoUeLNny7daCs0C8lxR9+CJO6/Rc9tLKSioRzR7VW/cj3Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T6T5bVf+bsq8mbCE7gDwlLjRTcUxTZtBxbmf4XmSYwHyCRmyNF/gmkvQctuuEqRVAA3gx9wHv1KR30u7b4Fr0cz4PzFRJIJUP36hqiHyLuPBuU7f8zLkPVBQNP8EeymSRK2XSKJNORRr8+5+XRp/QFlSmXaaXVkBh66MAtjR01bVaj+d0nCKakx3kTohpf6Li6IxvUDF+Mn+hyUMqgX16nBocdY0qiR4AW4MGPLeuF5o6UEriE+EL2VKrc3hlWJTmMfju7T2M9XQd4b8ZBDl+aQESNelmmq3dd6dRyl7+LrDO/xeeGFF+n0xo3NEfVOjE8iYUKCwoAXVFnS68TCiOA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bertrand.Marquis@xxxxxxx, Wei.Chen@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx
- Delivery-date: Tue, 16 Nov 2021 11:31:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.11.2021 10:44, Julien Grall wrote:
> On 16/11/2021 07:49, Jan Beulich wrote:
>> On 16.11.2021 07:31, Penny Zheng wrote:
>>> v3 changes:
>>> - move flag XEN_DOMCTL_CDF_INTERNAL_directmap back to
>>> xen/include/xen/domain.h,
>>> to let it be only available for domain created by XEN.
>>> - name it with extra "INTERNAL" and add comments to warn developers not
>>> to accidently use its bitfield when introducing new XEN_DOMCTL_CDF_xxx flag.
>>
>> FTR I continue to object to the hijacking of a public interface bit for
>> this purpose. Not to the degree of nak-ing the change, but still.
>
> I remember this discussion in v1 and I am a bit confused why this was
> re-introduced. Looking at the thread, I think you and I were happy with
> the following approach:
>
> 1) Switch the last parameter of domain_create() (i.e. bool is_priv)
> to flags.
> 2) Define a bit in the parameter to indicate whether the domain will
> be direct-mapped.
Indeed, that's how I too would prefer this to be dealt with.
Jan
|
