[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/5] xen/domain: Remove function pointers from domain pause helpers


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 16 Nov 2021 08:15:45 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/vGvseAI65bUvbGhMv5fuW5MzvhiHtpP1y1aNVYnVxg=; b=fL8JBLh48vKZ8pmmV7VgSkjWNvwS7DaCJIRvVwqIrT+ZDgaVM4Qgb+pa9yBAAwtKReL5sDHVUMiRjrrhRgqLItaMzs+JYTaar7rN1/dcL675lDjtpog6enIuy68g62N/a8TCGTkJPa0Mzwvoa1KUPv9/g1f3uyQYRxKxPIwavR6inCGpMnLj0BIJa42VB70r8oFIFF7Nj24MatFu54XCXh5TMGCAf6vroXfODFBFaPMlbdqQS+FwQTs39yW2KGeJf+EKwRHpEBcwPIynEvZO7Y9XIHk95DmhgMQy6eHYJkvKdxUrTDYabmGkYgaqG1Ijarsm1Z60J1Upi1S3GfS3ZA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S4LyZNf/yt57DekwMwZFS6YYkZdFo6rvWvZK2mNOPxnmcjoEn+hLFm+feaap3HmE3Uuae2vlFWkI+YVighvkSn6eKF6q+Z8ih2vF2cz8aV0GNgoTE8NEuK0+IFTat1D61BNZ9RDJdzjo5R0CYrlsooqWqXjHMZJhTEMH2GD0q5yp0Uis95pCSfXTGnZ7MrOYq8yl77KsMVoINhY6RoXSv5ApNyeLiiCTYJlWB3PLnbSOCk2lmOMbMz+W1r3bgwDJuUK+vZ9UmQiPvXlNwOnG2g5MGhqpArUHdV7H9D7VgWi1BVUca/S07f7JxOFQBS82nV/drjf4VbAnW2ei9VlOQQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 16 Nov 2021 07:16:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16.11.2021 01:41, Stefano Stabellini wrote:
> Bertrand's comment about MISRA aside, this style of comments doesn't
> seem to be covered/allowed by our current CODING_STYLE. It would be good
> to keep the CODING_STYLE document up to date: not only it helps us
> during reviews, it also helps contributors making sure they don't
> violate our guidelines. Moreover CODING_STYLE will certainly turn out
> useful when we are going to have MISRA discussion so that we can have an
> up-to-date reference of what we currently do and support.

Well, yes. My track record of getting changes to this file accepted is
so poor that I'm afraid I'm not willing to make a patch.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.