[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN][RFC PATCH v2 10/12] tools/libs/ctrl: Implement new xc interfaces for dt overlay
- To: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Fri, 12 Nov 2021 14:21:39 +0000
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <julien@xxxxxxx>, <bertrand.marquis@xxxxxxx>, <volodymyr_babchuk@xxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Fri, 12 Nov 2021 14:21:54 +0000
- Ironport-data: A9a23:A9lFXKIR4yB1fnUqFE+Rm5MlxSXFcZb7ZxGr2PjKsXjdYENSgWMAy jAYXGuPbvyNNmWhLth3Ptm3pE9QuMPdyNI2GgVlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZUideSc+EH140Es6wbZj6mJVqYPR7z2l6 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Csel2y dYS6aaNChwwZpDmwtgYWEBhRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr LpBdW5LPkvra+GemdpXTsFlgNgjK8/6epsSoHh6wRnSDOo8QICFSKLPjTNd9Gph2J0STaeDD yYfQR4/NBHvQy9pAUkaL7QBs6CUmGf5LRQN/Tp5ooJoujOOnWSdyoPFMcXXUsyHQ91PmUSVr X6A+H72ajkEM9iYxSuA42ibjObFliPmW6ofDLS9sPVthTW7xGMJDwYNfUCmuvT/gUm7M/pAL 2QE9yxoqrI9nGShQ8PhRRS+rDiBtwQFRttLO+Qg7UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq1+LGJ6y2zOjIcKEcSZCsFSxtD6N7myKkxkxbOQ9BLAKOzyNrvFlnY2 CuWpSIzg7ESi88j1Kih+13DxTW2qfD0ohUdv1uNGDj/t0UgOdDjN9fABUXnAehoJ6igSViC4 yQ+pouF9bgzJ8uxkSfUebBYdF223MqtPDrZiF9pOpAu8TWx5nKuFbxtDCFCyFRBaZhdJ2KwC KPHkUYIvcIIYiP2BUNiS9vpU5xC8ET2KTjyuhk4hPJqa4M5SgKI9ToGiaW4jzG0yxhEfU3S1 P6mnSeQ4ZQyVfsPINmeHb51PVoXKsYWnz67qXfTlUTP7FZmTCTJIYrpyXPXBgzD0IuKoR/O7 /FUPNaQxhNUXYXWO3eMr9BOcwpRdilmX/gaTvC7kMbZf2KK/0l7W5fsLU4JIdQ5z8y5aM+Ul p1CZqOo4AWm3iCWQel7QntidKnuTf5CQYETZkQR0aKT8yF7O+6Htf5HH7NuJOVP3LEznJZcE qheE+3dU6snd9gy02lEBXULhNc5L0rDaMPnF3fNXQXTiLY8HVGUoYG9IVO0nMTMZwLu3fYDT 3Sb/luzafI+q85KV646sdqjkAG8u2YzguV3UxeaK9VfYhy0ooNrNzbwnrk8JMRVcUfPwT6T1 gC3BxYEpLaS/99poYeR3a3U/Z20F+ZeH1ZBGzWJ57iBKiSHrHGoxpVNUbjUcGmFBn/04qire c5c0+r4bK8chF9PvoclS+RrwKsy6sHBvbhfygg4TnzHY07yUuFrI2Wc3NkJvapIn+cLtQyzU 0OJ299bJbTWZ5+1TA9PfFIoN73R2+sVlz/e6eUODH/7vCInrqCaVUhyPgWXjHAPJrVCL454k /wqv9Qb6lLjh0NyYMqGlC1d60+FMmcED/c8rpgfDYLm1lgrx1VFbcCOAyP6+sjSOdBFM01sK T6InqvSwb9bwxOaIXY0EHHM28tbhIgP508WnANTeQzRl4qXnOIz0T1Q7S8zH1ZcwRhw2u5uP nRmah9uLqKU8jY03MVOUghAwe2a6MF1LqAp92Y0qQ==
- Ironport-hdrordr: A9a23:EhJepawnrcinrgLJfM7JKrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU=
- Ironport-sdr: k1iMMWY6VSdUrONqWuWD2Do0ah8bvWhE9hIlXrXIho2iyPZD9qVbF9w/sqFOaOwGX2fWScZ/nX iwhs5QmhZcVAvTxTZiboo+5X8tIdCvGPj0ywp8BsnABWwHw7mukcb+1LWtO3YNYhzz/nBnFglv fjL5b7jWMuEsw+6lbcs7lO6MJK+eEc/Q7tYCdjMGEEljW+dTJhGpHlNupCqp6UHHyFgXx3moc+ LOzy7wDFNn5erJKTEZK+iovyPYbym3jqsZKYpIiZ/V86dwa6tOW8EakhlsR/4Z4wEugBB15hTs WSVWyDOeRp1thnc9Lhj8KHfE
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Nov 11, 2021 at 11:46:36AM -0800, Vikram Garhwal wrote:
> On Thu, Nov 11, 2021 at 04:54:25PM +0000, Anthony PERARD wrote:
> Hi Anthony,
> > On Mon, Nov 08, 2021 at 11:02:25PM -0800, Vikram Garhwal wrote:
> > > +SRCS-$(CONFIG_OVERLAY_DTB) += xc_overlay.c
> >
> > So, this patch seems to introduce the use of CONFIG_OVERLAY_DTB, is
> > there a reason why the new functionality can't be always builtin?
> >
> Above, if you meant removing "CONFIG_OEVRLAY_DTB" then here is my answer:
> This feature is supported by ARM based FPGA devices only so there were a few
> comments on v1 series to keep the code inside a config only. Now, for the tool
> side also I kept the CONFIG_OVERLAY_DTB to align the xen-tools with Xen.
>
> Although, now i saw your comments on patch 10 regarding "always provide
> libxl_dt_overlay() but which would return ENOSYS when libxl is built without
> CONFIG_OVERLAY_DTB". That seems better approach here for all three xen-tool
> patches.
>
> Initially, i was not sure what to do here that's why i wrote a question in the
> cover letter about this.
>
> Also, do you know how to enable this config via menuconfig when building the
> Xen
> tools? I know how to enable for Xen but not sure about tools.
It isn't possible to use the configuration of the hypervisor to build
the tool. We use autoconf (configure.ac, ...) to configure the tools but
I don't think in this case that having CONFIG_OVERLAY_DTB for the tools
is the right thing to do. In the tools, we don't really have a way to
select functionalities available in the different libraries, or it is
mostly based on the architecture or operating system or available
system libraries.
Contrary to the hypervisor side, the added code in the libraries is
mostly glue which calls the hypervisor, so their isn't really a need to
avoid building it. If the functionality isn't available in the
hypervisor, it should return an error and the library can deal with that
error.
You might want to limit the build to Arm, but I don't know if that
"overlay dtb" thing is really Arm specific (even though device trees are
mostly use on Arm I guess).
--
Anthony PERARD
|
